Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode? #10

Open
Bryntet opened this issue Dec 19, 2022 · 1 comment
Open

Darkmode? #10

Bryntet opened this issue Dec 19, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Bryntet
Copy link

Bryntet commented Dec 19, 2022

Is your feature request related to a problem? Please describe.
I don't like my eyes hurting

Describe the solution you'd like
I would like a dark mode

Additional context
Thank you very much <3

@kernc
Copy link
Member

kernc commented Dec 21, 2022

Thanks for your message.

I thought dark mode was already available and builtin into Qt as it was working out-of-the-box on macOS, but apparently not the case on Windows and Linux.

On Linux, it's a bit fiddly for the time being, but on Windows, passing CLI argument -platform windows:darkmode=2 (you can amend your shortcut) is supposed to work, albeit experimentally:
Screenshot_2022-12-20_12-07-57
We should, probably, include that extra argument in PyInstaller Windows build or, if passing extra args that way is not possible, we might fix sys.args on app init:

efck/efck/__init__.py

Lines 12 to 13 in 4caac2d

import sys
qApp = QApplication(sys.argv)

@kernc kernc added enhancement New feature or request good first issue Good for newcomers labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Development

No branches or pull requests

2 participants