Skip to content

Commit 86773e9

Browse files
BenjaminBossangithubnemo
authored andcommitted
FIX: Generation nightly CI failing due to gemma (huggingface#2580)
For a month now, nightly CI has failed with dozens of tests causing this error: > RuntimeError: Offset increment outside graph capture encountered unexpectedly. (link: https://github.com/huggingface/peft/actions/runs/14850392078/job/41692748031) It turns out that huggingface#2458, which added a gemma model to the test suite, is most likely the culprit. Since that commit, on nightly CI (with GPU), when transformers generates with gemma, which uses torch.compile, an error can be triggered. For some reason, this has a side effect on other tests that then results in the error quoted above. As is, there is no solution for the gemma issue. To still allow the tests to run and help discover potential issues, this PR skips the corresponding gemma tests, which should allow the other tests to pass again. I could confirm locally that these tests only fail when the gemma tests are run in the same session. Hopefully, this generalizes to the CI environment. --------- Co-authored-by: githubnemo <[email protected]>
1 parent 41bf437 commit 86773e9

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,12 @@ tests_core_multi_gpu:
3131
tests_core_single_gpu:
3232
python -m pytest -m single_gpu_tests tests/test_common_gpu.py $(if $(IS_GITHUB_CI),--report-log "core_single_gpu.log",)
3333

34+
# exclude gemma tests, as generation fails with torch.compile, these failures
35+
# trigger side effects that make other tests fail with 'RuntimeError: Offset
36+
# increment outside graph capture encountered unexpectedly.'
37+
# TODO re-enable gemma once/if it is fixed
3438
tests_common_gpu:
35-
python -m pytest tests/test_decoder_models.py $(if $(IS_GITHUB_CI),--report-log "common_decoder.log",)
39+
python -m pytest tests/test_decoder_models.py -k "not gemma" $(if $(IS_GITHUB_CI),--report-log "common_decoder.log",)
3640
python -m pytest tests/test_encoder_decoder_models.py $(if $(IS_GITHUB_CI),--report-log "common_encoder_decoder.log",)
3741
python -m pytest tests/test_gptqmodel.py $(if $(IS_GITHUB_CI),--report-log "gptqmodel_gpu.log",)
3842

0 commit comments

Comments
 (0)