Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies #860

Open
ronkorving opened this issue Feb 20, 2020 · 1 comment
Open

Dependencies #860

ronkorving opened this issue Feb 20, 2020 · 1 comment

Comments

@ronkorving
Copy link

Shouldn't jquery and jquery-ui be peerDependencies instead of dependencies? The current setup will install the jquery of your choice, instead of my choice, which is already in my app.
@mlh758
Copy link
Collaborator

mlh758 commented Feb 20, 2020

That seems like a reasonable change, feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ronkorving @mlh758