Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menuHeight: "auto" should subtract the header height and other externalities when computing the max height #869

Open
CarLuva opened this issue Mar 12, 2021 · 0 comments

Comments

@CarLuva
Copy link

CarLuva commented Mar 12, 2021

What is the current behavior?

If you set menuHeight to "auto" when the number of options is large, the menu (with header) will be taller than the inner height of the window, resulting in adding a scrollbar to the document body.

What is the expected behavior?

The menu should not exceed the inner height of the window, so that a scrollbar is not added. I believe the problem is that, in _setMenuHeight(), there is no adjustment made for the height of the header. Thus it will allow the height of $checkboxes to reach the full height of the window; the header (plus any top and bottom margin/padding/borders on the surrounding div) is added to the top of this, it makes the overall height of the menu exceed the height of the window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant