Skip to content

Commit

Permalink
TrackerMeasurementFromHits: fix time component of covariance (#1666)
Browse files Browse the repository at this point in the history
This value is not used yet, but should be squared, in principle.

### Briefly, what does this PR introduce?


### What kind of change does this PR introduce?
- [x] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?

### Does this PR change default behavior?
  • Loading branch information
veprbl authored Nov 11, 2024
1 parent 45eddf4 commit 7949889
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/algorithms/tracking/TrackerMeasurementFromHits.cc
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ namespace eicrecon {
meas2D.setLoc({static_cast<float>(pos[0]),static_cast<float>(pos[1])}); // 2D location on surface
meas2D.setTime(hit.getTime()); // Measurement time
// fixme: no off-diagonal terms. cov(0,1) = cov(1,0)??
meas2D.setCovariance({cov(0,0),cov(1,1),hit.getTimeError(),cov(0,1)}); // Covariance on location and time
meas2D.setCovariance({cov(0,0), cov(1,1), hit.getTimeError() * hit.getTimeError(), cov(0,1)}); // Covariance on location and time
meas2D.addToWeights(1.0); // Weight for each of the hits, mirrors hits array
meas2D.addToHits(hit);
}
Expand Down

0 comments on commit 7949889

Please sign in to comment.