-
Notifications
You must be signed in to change notification settings - Fork 34
Update FEMC for new geometry: #1848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akioogawa
wants to merge
54
commits into
main
Choose a base branch
from
FEMCupdate20250501
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−24
Open
Changes from 40 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
0a558ae
Update FEMC for new geometry:
akioogawa 79ff346
Merge branch 'main' into FEMCupdate20250501
akioogawa 93febe8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 581c4b4
typo
akioogawa 1d70ff4
Merge branch 'main' into FEMCupdate20250501
akioogawa ee01baf
Merge branch 'main' into FEMCupdate20250501
akioogawa 3096e5e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3c04b82
Merge branch 'main' into FEMCupdate20250501
akioogawa 668fdf4
Merge branch 'main' into FEMCupdate20250501
akioogawa e0e7b92
Merge branch 'main' into FEMCupdate20250501
akioogawa 10bd338
- Update ScFi model's Sampling Faction from 3% to 2.9% based on ratio…
akioogawa 1b7f3b7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 32d7d30
Merge branch 'main' into FEMCupdate20250501
akioogawa f6ee7de
Merge branch 'main' into FEMCupdate20250501
akioogawa 6965701
Update src/detectors/FEMC/FEMC.cc
akioogawa 83e634a
Update src/detectors/FEMC/FEMC.cc
akioogawa d186248
Update src/detectors/FEMC/FEMC.cc
akioogawa 02979bc
Remove 3 lines for old code compatibility
akioogawa 7b5e952
Revert back
akioogawa cb4265d
add back empty line
akioogawa 5aaa220
Merge branch 'main' into FEMCupdate20250501
akioogawa 6d65460
Changed to use #1064
akioogawa c8645a8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 50fffe9
add copyright, use fmt::format, remove commented code
veprbl 399e6ee
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b0d7e64
Replace fmt/base.h with fmt/core.h
veprbl 036a3c0
fix EcaslEndcapP typo, add consistent prefixes
veprbl 320cf88
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 80d23d2
Change totalPixel type to unsigned long long
veprbl 956453f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 37fe322
Fix field initialization in FEMC.cc
veprbl 01f50e6
reorder again
veprbl 3b8fd8b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4568907
fields go last
veprbl d71d25f
Merge branch 'main' into FEMCupdate20250501
veprbl b0d3d12
Update FEMC for new geometry: (fix: iwyu) (#2156)
wdconinc 0e7b743
address clang-tidy comments
veprbl 062f231
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 1e93ae3
Update src/detectors/FEMC/FEMC.cc
veprbl 7aecce9
Update FEMC for new geometry: (fix: iwyu) (#2157)
wdconinc 2511b2f
Rename FEMCHomoScFi to EcalEndcapP_homogeniousFlag
veprbl efef380
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3c15a25
Update EcalEndcapPRawHits parameters in FEMC.cc
veprbl 3249c9d
Fix typo in homogeneousFlag variable name
veprbl 0fafb40
Merge branch 'main' into FEMCupdate20250501
akioogawa 74dbeb0
Merge branch 'main' into FEMCupdate20250501
akioogawa c3e641a
"fiberx -> fiber_x (consistency with the other scfi implementations)
veprbl b0444c6
adjust some comments
veprbl 5568d72
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6ab3799
remove empty line
veprbl 087ad94
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3fc4c41
Update light collection efficiency with better number
akioogawa 82bfaec
Remove summing over x and y for ScFi case (recent changes applied to …
veprbl 8d5aa2e
naming
veprbl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.