Secvertex amvf to be merged into main EICrecon repo #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into displacedvertex
… into displacedvertex
for more information, see https://pre-commit.ci
Author
Moved to Config |
wdconinc
reviewed
Jul 28, 2025
Contributor
wdconinc
left a comment
wdconinc
left a comment
There was a problem hiding this comment.
Two major remaining comments from my side at this point:
- We should move the creation and initialization of algorithmic structures that are event-independent into the init function, not recreate them for each event in the process function.
- We should not base this algorithm on the input from ActsExamples::Trajectories, but on the input from ReconstructedParticles. That will avoid the combinatorics of the matching loop. (Even if you don't do this, the matching loop should use an early break.)
| float maxDistToLinPoint = 5.5 * Acts::UnitConstants::mm; | ||
| // Bin extent in z-direction | ||
| float spatialBinExtent = 25 * Acts::UnitConstants::um; | ||
| Acts::Vector4 initialVariances = Acts::Vector4{1e+2, 1e+2, 1e+2, 1e+8}; |
| @@ -0,0 +1,39 @@ | |||
| #pragma once | |||
| : SecondaryVertexFinderAlgorithm{name, | ||
| {"inputReconstructedParticles", "inputActsTrajectories"}, | ||
| {"outputPrimaryVertices", "outputSecondaryVertices"}, | ||
| ""} {} |
veprbl
reviewed
Nov 12, 2025
veprbl
reviewed
Nov 12, 2025
veprbl
reviewed
Nov 12, 2025
veprbl
reviewed
Nov 12, 2025
veprbl
reviewed
Nov 13, 2025
Comment on lines
+399
to
+400
| "PrimaryTrackVerticesAMVF", | ||
| "SecondaryTrackVerticesAMVF", |
Member
There was a problem hiding this comment.
Okay, so our IVF collection is CentralTrackVertices, we can't just replace Central with Primary.
Suggested change
| "PrimaryTrackVerticesAMVF", | |
| "SecondaryTrackVerticesAMVF", | |
| "CentralTrackVerticesAMVF", | |
| "CentralTrackSecondaryVerticesAMVF", |
Member
There was a problem hiding this comment.
Or if we are to be consistent with Xin's collections it would be
Suggested change
| "PrimaryTrackVerticesAMVF", | |
| "SecondaryTrackVerticesAMVF", | |
| "PrimaryVerticesAMVF", | |
| "SecondaryVerticesAMVF", |
I wonder if primaries and secondaries produced by this factory can overlap?
7 tasks
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Wouter Deconinck <[email protected]>
for more information, see https://pre-commit.ci
veprbl
reviewed
Nov 13, 2025
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/19345829824. Please merge this PR into the branch `secvertexAMVF` to resolve failures in PR #1915. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This adds secondary vertex finder to the EICrecon.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No need to make changes to existing code. Full compliance with main EICrecon repo has been maintained throughout
Does this PR change default behavior?
No change to default behaviour