Fix unchecked optional access warnings in tracking algorithms

.clang-tidy

@@ -9,7 +9,7 @@ Checks: '
   -bugprone-easily-swappable-parameters,
   -bugprone-macro-parentheses,
   -bugprone-narrowing-conversions,
-  -bugprone-unchecked-optional-access,
+
   -modernize-use-trailing-return-type,
   -modernize-avoid-c-arrays,
   -modernize-use-nodiscard,

.github/workflows/linux-eic-shell.yml

@@ -223,6 +223,24 @@ jobs:
       with:
         platform-release: "${{ env.platform }}:${{ env.release }}"
         run: |
+          # Run clang-tidy on specific files to check for bugprone-unchecked-optional-access warnings
+          echo "Running clang-tidy on PR files to check for bugprone-unchecked-optional-access warnings..."
+          PR_FILES=(
+            "src/algorithms/tracking/TrackPropagation.cc"
+            "src/algorithms/tracking/ActsToTracks.cc"
+            "src/benchmarks/reconstruction/tracking_efficiency/TrackingEfficiency_processor.cc"
+            "src/algorithms/tracking/TrackProjector.cc"
+          )
+          for file in "${PR_FILES[@]}"; do
+            if [[ -f "$file" ]]; then
+              echo "Checking $file for clang-tidy warnings..."
+              run-clang-tidy -p build -checks=bugprone-unchecked-optional-access -extra-arg='-std=c++20' "$file" || true
+            else
+              echo "File $file not found"
+            fi
+          done
+
+          # Original clang-tidy logic on changed files
           git diff ${{ github.event.pull_request.head.sha }} ${{ github.event.pull_request.base.sha }} | clang-tidy-diff -p 1 -path build -quiet -export-fixes clang_tidy_fixes.yaml -extra-arg='-std=c++20' -clang-tidy-binary run-clang-tidy
     - name: Run clang-tidy on all files
       uses: eic/run-cvmfs-osg-eic-shell@main
@@ -251,11 +269,12 @@ jobs:
       with:
         platform-release: "${{ env.platform }}:${{ env.release }}"
         run: |
+          git diff ${{ github.event.pull_request.head.sha }} ${{ github.event.pull_request.base.sha }} --name-only | tee changed_files.txt
           # reduce headers until diff is stable
           while [[ ${sha:-} != $(git diff | sha256sum) ]] ; do
             sha=$(git diff | sha256sum)
             echo $sha
-            iwyu_tool.py -p build $(git diff --name-only ${{ github.event.pull_request.head.sha }} ${{ github.event.pull_request.base.sha }}) -- -Xiwyu --verbose=3 -Xiwyu --no_fwd_decls -Xiwyu --cxx17ns -Xiwyu --mapping_file=${{github.workspace}}/.github/iwyu.imp -Xiwyu --regex=ecmascript | tee iwyu_fixes.log
+            iwyu_tool.py -p build $(cat changed_files.txt | grep -E '\.(cpp|cc|cxx|c\+\+)$' | paste -sd ' ') -- -Xiwyu --verbose=3 -Xiwyu --no_fwd_decls -Xiwyu --cxx17ns -Xiwyu --mapping_file=${{github.workspace}}/.github/iwyu.imp -Xiwyu --regex=ecmascript | tee iwyu_fixes.log
             fix_includes.py --blank_lines --nosafe_headers --reorder --separate_project_includes="<tld>" --keep_iwyu_namespace_format < iwyu_fixes.log
             git diff | tee iwyu_fixes.patch
           done

src/algorithms/tracking/ActsToTracks.cc

@@ -97,6 +97,10 @@ void ActsToTracks::process(const Input& input, const Output& output) const {
       // Get the fitted track parameter
       const auto& boundParam = traj->trackParameters(trackTip);
       const auto& parameter  = boundParam.parameters();
+      if (!boundParam.covariance().has_value()) {
+        m_log->warn("Track parameters do not have covariance matrix, skipping track");
+        continue;
+      }
       const auto& covariance = *boundParam.covariance();
 
       auto pars = track_parameters->create();

src/algorithms/tracking/TrackPropagation.cc

@@ -316,8 +316,16 @@ TrackPropagation::propagate(const edm4eic::Track& /* track */,
   m_log->trace("    propagation result is OK");
 
   // Pulling results to convenient variables
-  auto trackStateParams  = *((*result).endParameters);
-  const auto& parameter  = trackStateParams.parameters();
+  if (!(*result).endParameters.has_value()) {
+    m_log->trace("    propagation failed (endParameters not available)");
+    return nullptr;
+  }
+  auto trackStateParams = *((*result).endParameters);
+  const auto& parameter = trackStateParams.parameters();
+  if (!trackStateParams.covariance().has_value()) {
+    m_log->trace("    propagation failed (covariance not available)");
+    return nullptr;
+  }
   const auto& covariance = *trackStateParams.covariance();
 
   // Path length

src/benchmarks/reconstruction/tracking_efficiency/TrackingEfficiency_processor.cc

@@ -108,6 +108,10 @@ void TrackingEfficiency_processor::Process(const std::shared_ptr<const JEvent>&
     if (traj->hasTrackParameters(trackTip)) {
       const auto& boundParam = traj->trackParameters(trackTip);
       const auto& parameter  = boundParam.parameters();
+      if (!boundParam.covariance().has_value()) {
+        m_log->debug("Track parameters do not have covariance matrix");
+        continue;
+      }
       const auto& covariance = *boundParam.covariance();
       m_log->debug("{:>10.2f} {:>10.2f}  {:>10.2f} {:>10.3f} {:>10.4f} {:>10.3f} {:>12.4e} "
                    "{:>12.4e} {:>12.4e} {:>8.2f}",