refactor: use std::map for deterministic ordering in SimCalorimeterHitProcessor #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdconinc
force-pushed
the
SimCalorimeterHitProcessor-map
branch
from
29995b6 to
245c41a
Compare
…tProcessor (fix: iwyu) (#2162) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/18892744942. Please merge this PR into the branch `SimCalorimeterHitProcessor-map` to resolve failures in PR #2161. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Contributor
Author
|
Doesn't actually fix the lack of deterministic behavior... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR aims to remove the non-deterministic behavior between single- and multi-threading observed in e.g.
_EcalBarrelScFiPPulses_calorimeterHitsand brethren. Compared to unordered_map, we getAt this point (and maybe always), deterministic output outweighs performance consideration.
(*Technically since we don't do random lookups.)
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes, we might have slightly slower performance and better determinism.