Skip to content

Stop looking for primaries for simple radiative photon-like geometries #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Stop looking for primaries for simple radiative photon-like geometries #2178

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7510aae
Stop looking for calorimeter hit primaries if we enounter geometries …
sly2j Nov 6, 2025
c1133e1
Add extra condition to avoid storing first pair of early showers
sly2j Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/algorithms/calorimetry/SimCalorimeterHitProcessor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,23 @@ template <> struct hash<std::tuple<edm4hep::MCParticle, uint64_t, int>> {

// unnamed namespace for internal utility
namespace {
// Lookup primary MCParticle @TODO this should be a shared utiliy function in the edm4xxx
// Lookup primary MCParticle
// we stop looking if we find the parent has status 1 but with only 2 daughters
// so we don't merge radiative photons with the primary electron as this prevents us
// from properly linking the clusters back to the event geometry
// @TODO this should be a shared utiliy function in the edm4xxx
Copy link
Contributor

@wdconinc wdconinc Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file this as an issue in edm4eic?

Copy link
Contributor Author

@sly2j sly2j Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do - there are multiple copies of this function across multiple algorithms that we could get rid of.

Copy link
Contributor

@wdconinc wdconinc Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been meaning to ask copilot for code duplication... And enable that as a pre-commit or clang-tidy check...

Copy link
Member

@veprbl veprbl Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should modify other copies too?

Copy link
Contributor Author

@sly2j sly2j Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure as I don't know how they are used - I could see a case where this function could be somewhat configurable depending on use case - it wouldn't be too hard to add a parameter (could be templated or not) to steer the behavior. And/or have multiple versions with explicit different names that should be called by the user for clarity.

Copy link
Member

@veprbl veprbl Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also doesn't make sense to have different definitions under the same name.

I would just make the change and @ruse-traveler can confirm about other use cases.

// libraries
edm4hep::MCParticle lookup_primary(const edm4hep::CaloHitContribution& contrib) {
const auto contributor = contrib.getParticle();

edm4hep::MCParticle primary = contributor;
while (primary.parents_size() > 0) {
if (primary.getGeneratorStatus() != 0) {
auto parent = primary.getParents(0);
if (primary.getGeneratorStatus() != 0 ||
(parent.getGeneratorStatus() != 0 && parent.daughters_size() == 2)) {
break;
}
primary = primary.getParents(0);
primary = parent;
}
return primary;
}
Expand Down
Loading