tidy: Remove unused BackwardsBeamPipe_geo #991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused BackwardsBeamPipe_geo.cpp file as part of a codebase cleanup. The functionality previously provided by this file is now handled by the more comprehensive BeamPipeChain_geo implementation, which can manage both individual beampipe elements and properly join them together in chains.
Key Changes:
- Removal of obsolete BackwardsBeamPipe_geo.cpp detector factory implementation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
veprbl
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Remove the old BackwardsBeamPipe_geo file as it is currently unused. Current Beampipe geometry is now implemented using BeamPipeChain_geo which can handle both individual beampipe elements and correctly joining them together.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No