chore: change config option to record all transactions

Author: david-luna

docs/reference/configuration.md

@@ -368,9 +368,9 @@ If APM Server is deployed in an origin different than the page’s origin, you w
 ::::
 
 
-### `sendAllRouteChanges` [send-all-route-changes]
+### `recordEmptyTransactions` [record-empty-transactions]
 
 * **Type:** Boolean
 * **Default:** `false`
 
-This allows the agent to send all `route-change` transactions regardless if it contains any spans or not. This is usefull if you want to keep track of all the navigations your app is doing.
+If you are interested also for transactions that have no spans you can set this configuration option to true. Bear in mind that sampling rate still applies even if this setting is set to `true`.

packages/rum-core/src/common/config-service.js

@@ -96,7 +96,7 @@ class Config {
       session: false,
       apmRequest: null,
       sendCredentials: false,
-      sendAllRouteChanges: false
+      recordEmptyTransactions: false
     }
 
     this.events = new EventHandler()

packages/rum-core/src/performance-monitoring/performance-monitoring.js

@@ -48,8 +48,7 @@ import {
   OUTCOME_SUCCESS,
   OUTCOME_UNKNOWN,
   QUEUE_ADD_TRANSACTION,
-  TRANSACTION_IGNORE,
-  ROUTE_CHANGE
+  TRANSACTION_IGNORE
 } from '../common/constants'
 import {
   truncateModel,
@@ -362,13 +361,8 @@ export default class PerformanceMonitoring {
         return false
       }
 
-      if (tr.sampled && tr.spans.length === 0) {
-        if (
-          tr.type === ROUTE_CHANGE &&
-          this._configService.get('sendAllRouteChanges')
-        ) {
-          return true
-        }
+      const recordEmpty = this._configService.get('recordEmptyTransactions')
+      if (tr.sampled && tr.spans.length === 0 && !recordEmpty) {
         if (__DEV__) {
           this._logginService.debug(
             `transaction(${tr.id}, ${tr.name}) was discarded! Transaction does not have any spans`

packages/rum-core/test/performance-monitoring/performance-monitoring.spec.js

@@ -127,10 +127,10 @@ describe('PerformanceMonitoring', function () {
     )
   })
 
-  it('should allow route-change transactions with no spans if enabled by configuration', () => {
+  it('should allow transactions with no spans if enabled by configuration', () => {
     spyOn(logger, 'debug').and.callThrough()
-    configService.setConfig({ ...agentConfig, sendAllRouteChanges: true })
-    const transaction1 = new Transaction('/route/:id', 'route-change', {
+    configService.setConfig({ ...agentConfig, recordEmptyTransactions: true })
+    const transaction1 = new Transaction('transaction', 'custom', {
       id: 1,
       startTime: 0,
       managed: true