fix metricbeat aws module terraform and log errors (#47667)

Fix the metricbeat aws module terraform to ensure it uses a AMI compatible with the VM's platform.
Fix the `.buildkite/scripts/initCloudEnv.sh` to always log the output of `terraformSetup`

Author: AndersonQ

.buildkite/scripts/initCloudEnv.sh

@@ -53,19 +53,17 @@ terraformSetup() {
 
   while true; do
     echo "~~~ Setting up Terraform"
-    out=$(terraformApply 2>&1)
+    terraformApply 2>&1
     exit_code=$?
 
-    echo "$out"
-
     if [ $exit_code -eq 0 ]; then
       break
     else
       retries=$((retries + 1))
 
       if [ $retries -gt $max_retries ]; then
         teardown
-        echo "+++ Terraform init & apply failed: $out"
+        echo "+++ Terraform init & apply failed: check the logs above for details."
         exit 1
       fi
 

x-pack/metricbeat/module/aws/terraform.tf

@@ -79,4 +79,8 @@ data "aws_ami" "latest-amzn" {
       "amzn2-ami-hvm-*",
     ]
   }
+  filter {
+    name   = "architecture"
+    values = ["x86_64"]
+  }
 }