Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat] kafka input panics if expand_event_list_from_field points to field that isn't an array #36684

Open
leehinman opened this issue Sep 27, 2023 · 3 comments
Labels
Stalled Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@leehinman
Copy link
Contributor

If the kafka input has:

filebeat.inputs:
- type: kafka
  expand_event_list_from_field: records

And the records field is not an array (say a string). The code at

return []string{}
returns an empty slice. But later on this code tries to compose messages from this slice and it attempts to index into the 0 length slice here. That leads to a panic.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 27, 2023
@leehinman leehinman added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 27, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 27, 2023
@jlind23
Copy link
Collaborator

jlind23 commented Sep 27, 2023

@leehinman according to Beats CODEOWNERS file, this input belongs to @elastic/obs-infraobs-integrations, forwarding this to them.

@jlind23 jlind23 added Team:Service-Integrations Label for the Service Integrations team and removed Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Sep 27, 2023
@faec faec added Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed Team:Service-Integrations Label for the Service Integrations team labels Nov 8, 2023
@faec
Copy link
Contributor

faec commented Nov 8, 2023

Updating team assignment -- the Kafka module is owned by Integrations, but according to CODEOWNERS (and unless I missed the change) the input itself is still owned by Agent's data plane.

@botelastic
Copy link

botelastic bot commented Nov 7, 2024

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stalled Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

No branches or pull requests

3 participants