Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link with ^ doesn't work and adds values to the url #318

Closed
1 of 3 tasks
Tracked by #261
georgewallace opened this issue Jan 22, 2025 · 3 comments
Closed
1 of 3 tasks
Tracked by #261

Link with ^ doesn't work and adds values to the url #318

georgewallace opened this issue Jan 22, 2025 · 3 comments
Labels
authoring Relates to our markdown parser bug

Comments

@georgewallace
Copy link
Contributor

Describe the bug

On page https://bookish-dollop-9p66716.pages.github.io/es-connectors-usage.html#es-connectors-usage-syncs-cancel when you click the indicies privilege^ link it throws an error. if you manually go to https://bookish-dollop-9p66716.pages.github.io/security-privileges.html it works. The link provides the url https://bookish-dollop-9p66716.pages.github.io/%7B%7Bref%7D%7D/security-privileges.html
Image

Expected behavior

I would expect the link to work correctly.

Steps to reproduce

Navigate to https://bookish-dollop-9p66716.pages.github.io/ingest-enriching-data.html and click any of the SVGs and click indices privilege^

Tooling

  • docs-builder
  • migration tooling
  • I'm not sure
@bmorelli25
Copy link
Member

In the asciidoc build, what is the purpose of the carrot?

@bmorelli25 bmorelli25 added the authoring Relates to our markdown parser label Jan 23, 2025
@georgewallace
Copy link
Contributor Author

@bmorelli25 it looks like it opens it in a new page? Can test it on the asciidoc page.. that link opens a new tab where other links opens in existing tab. Didn't notice this on the old build.

https://www.elastic.co/guide/en/elasticsearch/reference/current/es-connectors-usage.html

@Mpdreamz
Copy link
Member

The bug is not because of ^ but because the link contains a variable.

`read` [indices privilege^]({{ref}}/security-privileges.html)

We added warnings for this here: #191

these should be rewritten to:

`read` [indices privilege^](/security-privileges.md)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authoring Relates to our markdown parser bug
Projects
None yet
Development

No branches or pull requests

3 participants