Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecctl deployment delete output is unhelpful on ESS #503

Open
3 of 4 tasks
gtback opened this issue Aug 20, 2021 · 0 comments
Open
3 of 4 tasks

ecctl deployment delete output is unhelpful on ESS #503

gtback opened this issue Aug 20, 2021 · 0 comments
Labels
enhancement New feature or request Team:Delivery

Comments

@gtback
Copy link
Member

gtback commented Aug 20, 2021

Readiness Checklist

  • I am running the latest version
  • I checked the documentation and found no answer
    The documentation does explain it, but I think the tool itself could be more intuitive
  • I checked to make sure that this issue has not already been filed
  • I am reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

If I run ecctl deployment delete against an ESS deployment, I should get a message saying something to the effect of:

ecctl deployment delete is for Elastic Cloud Enterprise only. For Elasticsearch Service (cloud.elastic.co), did you mean to use ecctl deployment shutdown?

Current Behavior

$ ecctl deployment delete <MY-DEPLOYMENT-ID>
[DELETE /deployments/{deployment_id}][404] deleteDeploymentNotFound  &{Errors:[]}`. 

The help text for this command does help (assuming I know what ECE is):

$ ecctl deployment delete --help
Deletes a previously shutdown deployment (Available for ECE only)

Usage:
  ecctl deployment delete <deployment-id> [flags]

Flags:
  -h, --help   help for delete

...

Steps to Reproduce

  1. Create a deployment in ESS
  2. Run ecctl deployment delete <THE-DEPLOYMENT-ID>

Possible Solution

Alternatively, this could just do The Right Thing ™️ and shutdown/delete the deployment.

Context

I was trying to delete a deployment I had just created in ESS (where the related UI text says "Delete deployment") and using the shell completions showed there was an ecctl deployment delete command, when I should have used ecctl deployment shutdown.

Your Environment

  • Version used: v1.5.0
  • Running against Elastic Cloud SaaS or Elastic Cloud Enterprise and version: ESS
  • Environment name and version (e.g. Go 1.9): go1.16.7
  • Server type and version: N/A
  • Operating System and version: macOS
  • Link to your project: N/A
Version:               v1.5.0
Client API Version:    2.11.0
Go version:            go1.16.7
Git commit:            39dffeee
Built:                 Wed 18 Aug 13:33:30 2021
OS/Arch:               darwin / amd64
@marclop marclop added the enhancement New feature or request label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Delivery
Projects
None yet
Development

No branches or pull requests

2 participants