[chore][windows/perf] Add methods for fetching raw counter values (#252)

* chore: add PDH helpers

* remove println

* add arm

* skip autogenerated code

* chore: add raw counters

* expose MatchInstanceName

* fix: remve AddCounter

Author: VihasMakwana

helpers/windows/pdh/pdh_query_windows.go

@@ -88,7 +88,7 @@ func (q *Query) AddCounter(counterPath string, instance string, format string, w
 	var instanceName string
 	// Extract the instance name from the counterPath.
 	if instance == "" || wildcard {
-		instanceName, err = matchInstanceName(counterPath)
+		instanceName, err = MatchInstanceName(counterPath)
 		if err != nil {
 			return err
 		}
@@ -203,6 +203,17 @@ func (q *Query) GetCountersAndInstances(objectName string) ([]string, []string,
 	return UTF16ToStringArray(counters), UTF16ToStringArray(instances), nil
 }
 
+func (q *Query) GetRawCounterValue(counterName string) (*PdhRawCounter, error) {
+	if _, ok := q.Counters[counterName]; !ok {
+		return nil, fmt.Errorf("%s doesn't exist in the map; call AddCounter()", counterName)
+	}
+	c, err := PdhGetRawCounterValue(q.Counters[counterName].handle)
+	if err != nil {
+		return nil, err
+	}
+	return c, nil
+}
+
 // ExpandWildCardPath  examines local computer and returns those counter paths that match the given counter path which contains wildcard characters.
 func (q *Query) ExpandWildCardPath(wildCardPath string) ([]string, error) {
 	if wildCardPath == "" {
@@ -255,7 +266,7 @@ func (q *Query) Close() error {
 }
 
 // matchInstanceName will check first for instance and then for any objects names.
-func matchInstanceName(counterPath string) (string, error) {
+func MatchInstanceName(counterPath string) (string, error) {
 	matches := instanceNameRegexp.FindStringSubmatch(counterPath)
 	if len(matches) == 2 {
 		return returnLastInstance(matches[1]), nil

helpers/windows/pdh/pdh_query_windows_test.go

@@ -91,42 +91,42 @@ func TestSuccessfulQuery(t *testing.T) {
 
 func TestMatchInstanceName(t *testing.T) {
 	query := "\\SQLServer:Databases(*)\\Log File(s) Used Size (KB)"
-	match, err := matchInstanceName(query)
+	match, err := MatchInstanceName(query)
 	assert.NoError(t, err)
 	assert.Equal(t, match, "*")
 
 	query = " \\\\desktop-rfooe09\\per processor network interface card activity(3, microsoft wi-fi directvirtual (gyfyg) adapter #2)\\dpcs queued/sec"
-	match, err = matchInstanceName(query)
+	match, err = MatchInstanceName(query)
 	assert.NoError(t, err)
 	assert.Equal(t, match, "3, microsoft wi-fi directvirtual (gyfyg) adapter #2")
 
 	query = " \\\\desktop-rfooe09\\ (test this scenario) per processor network interface card activity(3, microsoft wi-fi directvirtual (gyfyg) adapter #2)\\dpcs queued/sec"
-	match, err = matchInstanceName(query)
+	match, err = MatchInstanceName(query)
 	assert.NoError(t, err)
 	assert.Equal(t, match, "3, microsoft wi-fi directvirtual (gyfyg) adapter #2")
 
 	query = "\\RAS\\Bytes Received By Disconnected Clients"
-	match, err = matchInstanceName(query)
+	match, err = MatchInstanceName(query)
 	assert.NoError(t, err)
 	assert.Equal(t, match, "RAS")
 
 	query = `\\Process (chrome.exe#4)\\Bytes Received By Disconnected Clients`
-	match, err = matchInstanceName(query)
+	match, err = MatchInstanceName(query)
 	assert.NoError(t, err)
 	assert.Equal(t, match, "chrome.exe#4")
 
 	query = "\\BranchCache\\Local Cache: Cache complete file segments"
-	match, err = matchInstanceName(query)
+	match, err = MatchInstanceName(query)
 	assert.NoError(t, err)
 	assert.Equal(t, match, "BranchCache")
 
 	query = `\Synchronization(*)\Exec. Resource no-Waits AcqShrdStarveExcl/sec`
-	match, err = matchInstanceName(query)
+	match, err = MatchInstanceName(query)
 	assert.NoError(t, err)
 	assert.Equal(t, match, "*")
 
 	query = `\.NET CLR Exceptions(test hellp (dsdsd) #rfsfs #3)\# of Finallys / sec`
-	match, err = matchInstanceName(query)
+	match, err = MatchInstanceName(query)
 	assert.NoError(t, err)
 	assert.Equal(t, match, "test hellp (dsdsd) #rfsfs #3")
 }

helpers/windows/pdh/pdh_windows.go

@@ -101,6 +101,14 @@ type PdhCounterValueLong struct {
 	Pad_cgo_1 [4]byte
 }
 
+type PdhRawCounter struct {
+	CStatus     uint32
+	TimeStamp   windows.Filetime
+	FirstValue  int64
+	SecondValue int64
+	MultiCount  uint32
+}
+
 // PdhOpenQuery creates a new query.
 func PdhOpenQuery(dataSource string, userData uintptr) (PdhQueryHandle, error) {
 	var dataSourcePtr *uint16
@@ -198,6 +206,16 @@ func PdhGetFormattedCounterValueLong(counter PdhCounterHandle) (uint32, *PdhCoun
 	return counterType, &value, nil
 }
 
+// PdhGetRawCounterValue returns the raw value of a given counter.
+func PdhGetRawCounterValue(counter PdhCounterHandle) (*PdhRawCounter, error) {
+	var value PdhRawCounter
+	if err := _PdhGetRawCounter(counter, uintptr(unsafe.Pointer(&value))); err != nil {
+		return &value, PdhErrno(err.(syscall.Errno))
+	}
+
+	return &value, nil
+}
+
 // PdhExpandWildCardPath returns counter paths that match the given counter path.
 func PdhExpandWildCardPath(utfPath *uint16) ([]uint16, error) {
 	var bufferSize uint32