fixes for linter

Author: leehinman

monitoring/adapter/go-metrics.go

@@ -63,7 +63,7 @@ func GetGoMetrics(parent *monitoring.Registry, name string, filters ...MetricFil
 	if v == nil {
 		return NewGoMetrics(parent, name, filters...)
 	}
-	return newGoMetrics(v.(*monitoring.Registry), filters...)
+	return newGoMetrics(v.(*monitoring.Registry), filters...) //nolint:errcheck //code depends on panic
 }
 
 // NewGoMetrics creates and registers a new GoMetricsRegistry with the parent

monitoring/adapter/go-metrics_test.go

@@ -116,16 +116,16 @@ func TestGoMetricsHistogramClearOnVisit(t *testing.T) {
 	monReg := monitoring.NewRegistry()
 	histogramSample := metrics.NewUniformSample(10)
 	clearedHistogramSample := metrics.NewUniformSample(10)
-	NewGoMetrics(monReg, "original", Accept).Register("histogram", metrics.NewHistogram(histogramSample))
-	NewGoMetrics(monReg, "cleared", Accept).Register("histogram", NewClearOnVisitHistogram(clearedHistogramSample))
+	_ = NewGoMetrics(monReg, "original", Accept).Register("histogram", metrics.NewHistogram(histogramSample))
+	_ = NewGoMetrics(monReg, "cleared", Accept).Register("histogram", NewClearOnVisitHistogram(clearedHistogramSample))
 	dataPoints := [...]int{2, 4, 8, 4, 2}
 	dataPointsMedian := 4.0
 	for _, i := range dataPoints {
 		histogramSample.Update(int64(i))
 		clearedHistogramSample.Update(int64(i))
 	}
 
-	pre_snapshot := []struct {
+	preSnapshot := []struct {
 		expected any
 		actual   any
 		msg      string
@@ -152,7 +152,7 @@ func TestGoMetricsHistogramClearOnVisit(t *testing.T) {
 		},
 	}
 
-	for _, tc := range pre_snapshot {
+	for _, tc := range preSnapshot {
 		require.Equal(t, tc.expected, tc.actual, tc.msg)
 	}
 
@@ -163,7 +163,7 @@ func TestGoMetricsHistogramClearOnVisit(t *testing.T) {
 	// clearedHistogramSample have been reset to zero, but the
 	// snapshot reports the values before the clear
 
-	post_snapshot := []struct {
+	postSnapshot := []struct {
 		expected any
 		actual   any
 		msg      string
@@ -210,7 +210,7 @@ func TestGoMetricsHistogramClearOnVisit(t *testing.T) {
 		},
 	}
 
-	for _, tc := range post_snapshot {
+	for _, tc := range postSnapshot {
 		require.Equal(t, tc.expected, tc.actual, tc.msg)
 	}
 }

monitoring/adapter/histogram.go

@@ -78,7 +78,7 @@ func (h *ClearOnVisitHistogram) Sample() metrics.Sample {
 
 // Snapshot returns a read-only copy of the histogram.
 func (h *ClearOnVisitHistogram) Snapshot() metrics.Histogram {
-	return &ClearOnVisitHistogramSnapshot{sample: h.sample.Snapshot().(*metrics.SampleSnapshot)}
+	return &ClearOnVisitHistogramSnapshot{sample: h.sample.Snapshot().(*metrics.SampleSnapshot)} //nolint:errcheck // codepath depends on panic
 }
 
 // StdDev returns the standard deviation of the values in the sample.