panic in logp

[florianl]

When updating elastic-agent-libs to the latest version v0.21.6, we ran into panics in out tests:

[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xefd1f0]

goroutine 20 [running]:
github.com/elastic/elastic-agent-libs/logp.(*Logger).Named(0x0, {0x17f02df, 0x3})
	/go/pkg/mod/github.com/elastic/elastic-agent-libs@v0.21.6/logp/logger.go:176 +0x30
github.com/elastic/elastic-agent-libs/transport/tlscommon.(*TLSConfig).ToConfig(0xc000312f70)
	/go/pkg/mod/github.com/elastic/elastic-agent-libs@v0.21.6/transport/tlscommon/tls_config.go:109 +0x1e5

We do configure the TLS part the following way:

tlscommon.LoadTLSServerConfig(cfg.TLS, logp.NewNopLogger())

[khushijain21]

Hello Florian,

I am not able to reproduce the same locally. Can you point out where exactly were you updating this and where did the panic occur?

[khushijain21]

Checking the mentioned PR

[florianl]

For the record:
@khushijain21 identified, that &tlscommon.TLSConfig{Verification: tlscommon.VerifyNone} was used for testing and so no logger was set. Which resulted in the panic.