Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flamechart] Add button to expand the flamechart covering the full screen #2628

Open
3 tasks done
cauemarcondes opened this issue Mar 19, 2025 · 4 comments
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@cauemarcondes
Copy link

Is your feature request related to a problem? Please describe.
It would be great to be able to maximize the Profiling flamegraph, sometimes the graph is too big and it's difficult to navigate through it.

Image

Describe the solution you'd like
Similar to the EuiDataGrid, it would be great to be able to toggle a maximize button on the top-right corner of the flamegraph.

Describe alternatives you've considered
N/A

Additional context
N/A

Kibana Cross Issues
N/A

Checklist

Delete any items that are not applicable to this feature request.

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@cauemarcondes cauemarcondes added the enhancement New feature or request label Mar 19, 2025
@cauemarcondes
Copy link
Author

If we thing that the maximize logic should not be handled by the flamechart component, I can implement it myself on the Profiling UI.

@markov00
Copy link
Member

What do you mean by maximize? expanding to cover the full screen? if that the case I believe this should be handled by the consumer so your Profiling UI

@cauemarcondes
Copy link
Author

What do you mean by maximize? expanding to cover the full screen?

Yes, I meant enter in full screen mode.

I asked that because maybe this would be a feature that could belong to the flamechart, like it belongs to the EuiDataGrid.

@cauemarcondes cauemarcondes changed the title [Flamechart] Add button to maximize flamecharts [Flamechart] Add button to expand the flamechart covering the full screen Mar 20, 2025
@christos68k
Copy link
Member

christos68k commented Mar 22, 2025

I asked that because maybe this would be a feature that could belong to the flamechart, like it belongs to the EuiDataGrid.

To me this sounds like the way to go. I can't imagine any flamegraph user not wanting this functionality. Any user spending significant time with flamegraphs would love the option to maximize the information shown and reduce the amount of scrolling and zooming one has to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants