Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LineAnnotationStyle and RectAnnotationStyle to Theme #362

Open
cchaos opened this issue Aug 29, 2019 · 0 comments
Open

Move LineAnnotationStyle and RectAnnotationStyle to Theme #362

cchaos opened this issue Aug 29, 2019 · 0 comments
Labels
:annotation Annotation (line, rect, text) related issue enhancement New feature or request :styling Styling related issue :xy Bar/Line/Area chart related

Comments

@cchaos
Copy link
Contributor

cchaos commented Aug 29, 2019

Describe the bug
Right now the defaults are declared as separate configs (just like the grid). This makes it harder to change these styles per theme (especially light vs dark).

Expected behavior
The Theme object should accept line and rect annotation styles.

Screenshots
Screen Shot 2019-08-22 at 17 08 45 PM

Version (please complete the following information):

  • Elastic Charts: 11.1.1
@cchaos cchaos added :annotation Annotation (line, rect, text) related issue :styling Styling related issue labels Aug 29, 2019
@markov00 markov00 added enhancement New feature or request :xy Bar/Line/Area chart related labels Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:annotation Annotation (line, rect, text) related issue enhancement New feature or request :styling Styling related issue :xy Bar/Line/Area chart related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cchaos @markov00