Skip to content

Commit db36a56

Browse files
authored
WriteEvent Option on ChannelOptionBase is never called (#74)
It is set in several ecs-dotnet projects but its never called here. IElasticsearchEventWriter<TEvent> is the right mechanism to override event serialization.
1 parent 2037c14 commit db36a56

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/Elastic.Channels/ChannelOptionsBase.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44

55
using System;
66
using System.Collections.Generic;
7-
using System.IO;
87
using System.Threading;
9-
using System.Threading.Tasks;
108
using Elastic.Channels.Buffers;
119
using Elastic.Channels.Diagnostics;
1210

@@ -32,11 +30,6 @@ public abstract class ChannelOptionsBase<TEvent, TResponse> : IChannelCallbacks<
3230
/// <summary> Provide an external cancellation token </summary>
3331
public CancellationToken? CancellationToken { get; set; }
3432

35-
/// <summary>
36-
/// Optionally provides a custom write implementation to a channel. Concrete channel implementations are not required to adhere to this config
37-
/// </summary>
38-
public Func<Stream, CancellationToken, TEvent, Task>? WriteEvent { get; set; } = null;
39-
4033
/// <inheritdoc cref="IChannelCallbacks{TEvent,TResponse}.ExportExceptionCallback"/>
4134
public Action<Exception>? ExportExceptionCallback { get; set; }
4235

0 commit comments

Comments
 (0)