From a5193d5ed30328919337567dadcb89c305f61630 Mon Sep 17 00:00:00 2001 From: Mario Rodriguez Molins Date: Thu, 6 Nov 2025 10:08:19 +0100 Subject: [PATCH 1/2] Show errors if any when updating managed setting in saved object --- internal/kibana/savedobjects.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/internal/kibana/savedobjects.go b/internal/kibana/savedobjects.go index c4c0c84a9..5e610e203 100644 --- a/internal/kibana/savedobjects.go +++ b/internal/kibana/savedobjects.go @@ -198,6 +198,13 @@ func (c *Client) SetManagedSavedObject(ctx context.Context, savedObjectType stri // Even if no error is returned, we need to check if the import was successful. if !resp.Success { + if len(resp.Errors) > 0 { + var errorMessages []string + for _, importError := range resp.Errors { + errorMessages = append(errorMessages, fmt.Sprintf("ID: %s, Type: %s, Error: %v", importError.ID, importError.Type, importError.Error)) + } + return fmt.Errorf("importing %s %s was not successful: %s", savedObjectType, id, strings.Join(errorMessages, "; ")) + } return fmt.Errorf("importing %s %s was not successful", savedObjectType, id) } From 22575c2b60c9bc94ba5a6c0d82f8ced43dbd9932 Mon Sep 17 00:00:00 2001 From: Mario Rodriguez Molins Date: Thu, 6 Nov 2025 19:26:11 +0100 Subject: [PATCH 2/2] Re-phrase error message --- internal/kibana/savedobjects.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/kibana/savedobjects.go b/internal/kibana/savedobjects.go index 5e610e203..d0c748b60 100644 --- a/internal/kibana/savedobjects.go +++ b/internal/kibana/savedobjects.go @@ -203,7 +203,7 @@ func (c *Client) SetManagedSavedObject(ctx context.Context, savedObjectType stri for _, importError := range resp.Errors { errorMessages = append(errorMessages, fmt.Sprintf("ID: %s, Type: %s, Error: %v", importError.ID, importError.Type, importError.Error)) } - return fmt.Errorf("importing %s %s was not successful: %s", savedObjectType, id, strings.Join(errorMessages, "; ")) + return fmt.Errorf("failed to import one or more saved objects: %s", strings.Join(errorMessages, "; ")) } return fmt.Errorf("importing %s %s was not successful", savedObjectType, id) }