Skip to content

Commit 143ef3b

Browse files
authored
Fix a null check for response which may happen during tests (#171)
Observed here during release: https://github.com/elastic/elastic-transport-net/actions/runs/15298217514/job/43032254002 These UsageTests were never actual tests but now we are running them hopefully this fixes it.
1 parent 9876ea7 commit 143ef3b

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/Elastic.Transport/DistributedTransport.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,13 @@ private async ValueTask<TResponse> RequestCoreAsync<TResponse>(
248248
}
249249
}
250250

251+
if (response is not null)
252+
{
251253
#if NET6_0_OR_GREATER
252-
activity?.SetStatus(response.ApiCallDetails.HasSuccessfulStatusCodeAndExpectedContentType ? ActivityStatusCode.Ok : ActivityStatusCode.Error);
254+
activity?.SetStatus(response.ApiCallDetails.HasSuccessfulStatusCodeAndExpectedContentType ? ActivityStatusCode.Ok : ActivityStatusCode.Error);
253255
#endif
254-
255-
activity?.SetTag(SemanticConventions.HttpResponseStatusCode, response.ApiCallDetails.HttpStatusCode);
256+
activity?.SetTag(SemanticConventions.HttpResponseStatusCode, response.ApiCallDetails.HttpStatusCode);
257+
}
256258
activity?.SetTag(OpenTelemetryAttributes.ElasticTransportAttemptedNodes, attemptedNodes);
257259

258260
// We don't check IsAllDataRequested here as that's left to the consumer.

0 commit comments

Comments
 (0)