Error converters need to be public so they can be used in other project's serializercontexts

Author: Mpdreamz

src/Elastic.Transport/Components/Serialization/Converters/ErrorCauseConverter.cs

@@ -12,10 +12,13 @@
 
 namespace Elastic.Transport;
 
-internal class ErrorCauseConverter : ErrorCauseConverter<ErrorCause> { }
+/// A JSON converter for <see cref="ErrorCause"/>
+public class ErrorCauseConverter : ErrorCauseConverter<ErrorCause> { }
 
-internal class ErrorConverter : ErrorCauseConverter<Error>
+/// A JSON converter for <see cref="Error"/>
+public class ErrorConverter : ErrorCauseConverter<Error>
 {
+	/// <inheritdoc cref="ErrorCauseConverter{T}.ReadMore"/>
 	protected override bool ReadMore(ref Utf8JsonReader reader, JsonSerializerOptions options, string propertyName, Error errorCause)
 	{
 		void ReadAssign<T>(ref Utf8JsonReader r, Action<Error, T> set) =>
@@ -36,16 +39,16 @@ void ReadAssign<T>(ref Utf8JsonReader r, Action<Error, T> set) =>
 	}
 }
 
-internal class ErrorCauseConverter<TErrorCause> : JsonConverter<TErrorCause> where TErrorCause : ErrorCause, new()
+/// A JSON converter for <see cref="ErrorCause"/> implementations
+public abstract class ErrorCauseConverter<TErrorCause> : JsonConverter<TErrorCause> where TErrorCause : ErrorCause, new()
 {
+	/// <inheritdoc cref="JsonConverter{T}.Read"/>
 	public override TErrorCause Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
 	{
 		if (reader.TokenType != JsonTokenType.StartObject)
-		{
 			return reader.TokenType == JsonTokenType.String
 				? new TErrorCause { Reason = reader.GetString() }
 				: null;
-		}
 
 		var errorCause = new TErrorCause();
 		var additionalProperties = new Dictionary<string, object>();
@@ -176,8 +179,10 @@ private static IReadOnlyCollection<string> ReadSingleOrCollection(ref Utf8JsonRe
 		}
 	}
 
+	/// Read additional properties for the particular <see cref="ErrorCause"/> implementation
 	protected virtual bool ReadMore(ref Utf8JsonReader reader, JsonSerializerOptions options, string propertyName, TErrorCause errorCause) => false;
 
+	/// <inheritdoc cref="JsonConverter{T}.Read"/>
 	public override void Write(Utf8JsonWriter writer, TErrorCause value, JsonSerializerOptions options)
 	{
 		writer.WriteStartObject();

src/Elastic.Transport/DistributedTransport.cs

@@ -29,7 +29,10 @@ public sealed class DistributedTransport(ITransportConfiguration configuration)
 {
 }
 
-/// <inheritdoc cref="ITransport{TConfiguration}" />
+/// <summary>
+/// Transport coordinates the client requests over the node pool nodes and is in charge of falling over on
+/// different nodes
+/// </summary>
 public class DistributedTransport<TConfiguration> : ITransport<TConfiguration>
 	where TConfiguration : class, ITransportConfiguration
 {

src/Elastic.Transport/Products/Elasticsearch/ErrorSerializationContext.cs

@@ -11,4 +11,6 @@ namespace Elastic.Transport.Products.Elasticsearch;
 /// Adds support for serializing Elasticsearch errors using <see cref="IJsonTypeInfoResolver"/>
 [JsonSerializable(typeof(Error))]
 [JsonSerializable(typeof(ErrorCause))]
+[JsonSerializable(typeof(ElasticsearchServerError))]
+[JsonSerializable(typeof(ElasticsearchResponse))]
 public partial class ErrorSerializerContext : JsonSerializerContext;

src/Elastic.Transport/Products/Elasticsearch/Failures/Error.cs

@@ -33,8 +33,10 @@ public override string ToString() => CausedBy == null
 		: $"Type: {Type} Reason: \"{Reason}\" CausedBy: \"{CausedBy}\"";
 }
 
-internal sealed class ErrorConverter : JsonConverter<Error>
+/// A JSON converter for <see cref="Error"/>.
+public sealed class ErrorConverter : JsonConverter<Error>
 {
+	/// <inheritdoc cref="JsonConverter{T}.Read"/>
 	public override Error Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
 	{
 		if (reader.TokenType == JsonTokenType.String)
@@ -129,5 +131,7 @@ public override Error Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe
 		throw new JsonException("Could not deserialise the error response.");
 	}
 
-	public override void Write(Utf8JsonWriter writer, Error value, JsonSerializerOptions options) => throw new NotImplementedException();
+	/// <inheritdoc cref="JsonConverter{T}.Read"/>
+	public override void Write(Utf8JsonWriter writer, Error value, JsonSerializerOptions options) =>
+		throw new NotImplementedException();
 }