Add fix for ServerError after moving to .NET5 (#9)

Author: Mpdreamz

.github/workflows/ci.yml

@@ -34,6 +34,8 @@ jobs:
 
     - run: ./build.sh build -s true
       name: Build
+    - run: ./build.sh test -s true
+      name: Test
     - run: ./build.sh generatepackages -s true
       name: Generate local nuget packages
     - run: ./build.sh validatepackages -s true

build/scripts/scripts.fsproj

@@ -6,10 +6,10 @@
     <IsPackable>false</IsPackable>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Argu" Version="6.0.0" />
-    <PackageReference Include="Bullseye" Version="3.3.0" />
+    <PackageReference Include="Argu" Version="6.1.1" />
+    <PackageReference Include="Bullseye" Version="3.5.0" />
     <PackageReference Include="Proc" Version="0.6.2" />
-    <PackageReference Include="Fake.Tools.Git" Version="5.15.0" />
+    <PackageReference Include="Fake.Tools.Git" Version="5.20.3" />
   </ItemGroup>
 
   <ItemGroup>

src/Elastic.Transport/Components/Connection/HttpWebRequestConnection.cs

@@ -9,10 +9,8 @@
 using System.IO.Compression;
 using System.Linq;
 using System.Net;
-using System.Net.Http;
 using System.Net.NetworkInformation;
 using System.Net.Security;
-using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 using Elastic.Transport.Diagnostics;
@@ -27,7 +25,7 @@ namespace Elastic.Transport
 	/// </para>
 	/// <para/>
 	/// <para>Do NOT use this class directly on .NET Core. <see cref="HttpWebRequest"/> is monkey patched
-	/// over <see cref="HttpClient"/> and does not reuse its instances of <see cref="HttpClient"/>
+	/// over HttpClient and does not reuse its instances of HttpClient
 	/// </para>
 	/// </summary>
 #if DOTNETCORE

src/Elastic.Transport/Configuration/UserAgent.cs

@@ -5,6 +5,7 @@
 using System;
 using System.Reflection;
 using System.Runtime.InteropServices;
+using Elastic.Transport.Extensions;
 
 namespace Elastic.Transport
 {

src/Elastic.Transport/Diagnostics/Diagnostic.cs

@@ -47,6 +47,6 @@ internal set
 
 
 		//_source can be null if Default instance
-		public void Dispose() => _source?.StopActivity(SetEndTime(DateTime.UtcNow), EndState);
+		protected override void Dispose(bool disposing) => _source?.StopActivity(SetEndTime(DateTime.UtcNow), EndState);
 	}
 }

src/Elastic.Transport/Elastic.Transport.csproj

@@ -16,10 +16,10 @@
   </PropertyGroup>
   <ItemGroup>
 
-    <PackageReference Include="Microsoft.CSharp" Version="4.6.0" />
-    <PackageReference Include="System.Buffers" Version="4.5.0" />
-    <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="4.5.1" />
-    <PackageReference Include="System.Text.Json" Version="4.7.1" />
+    <PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
+    <PackageReference Include="System.Buffers" Version="4.5.1" />
+    <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="5.0.0" />
+    <PackageReference Include="System.Text.Json" Version="5.0.0" />
 
   </ItemGroup>
 

src/Elastic.Transport/Products/Elasticsearch/Failures/ServerError.cs

@@ -15,7 +15,8 @@ namespace Elastic.Transport.Products.Elasticsearch.Failures
 	[DataContract]
 	public class ServerError
 	{
-		internal ServerError() { }
+		/// <inheritdoc cref="ServerError"/>
+		public ServerError() { }
 
 		/// <inheritdoc cref="ServerError"/>
 		public ServerError(Error error, int? statusCode)