Refactor, rename and seal various types (#44)

Author: stevejgordon

src/Elastic.Transport/Components/NodePool/Node.cs

@@ -12,7 +12,7 @@ namespace Elastic.Transport
 	/// <summary>
 	/// Represents an endpoint <see cref="Uri"/> with additional associated metadata on which the <see cref="ITransport{TConnectionSettings}"/> can act.
 	/// </summary>
-	public class Node : IEquatable<Node>
+	public sealed class Node : IEquatable<Node>
 	{
 		private IReadOnlyCollection<string> _features;
 
@@ -34,6 +34,7 @@ public Node(Uri uri, IEnumerable<string> features = null)
 		}
 
 		private HashSet<string> _featureSet;
+
 		/// <summary>
 		/// A readonly collection backed by an <see cref="HashSet{T}"/> that signals what features are enabled on the node.
 		/// <para> This is loosely typed as to be agnostic to what solution the transport ends up talking to </para>

src/Elastic.Transport/Components/NodePool/StickyNodePool.cs

@@ -13,7 +13,7 @@ namespace Elastic.Transport
 	/// A connection pool implementation that does not support reseeding and stays on the first <see cref="Node"/> reporting true for <see cref="Node.IsAlive"/>.
 	/// This is great if for instance you have multiple proxies that you can fallback on allowing you to seed the proxies in order of preference.
 	/// </summary>
-	public class StickyNodePool : StaticNodePool
+	public sealed class StickyNodePool : StaticNodePool
 	{
 		/// <inheritdoc cref="StickyNodePool"/>
 		public StickyNodePool(IEnumerable<Uri> uris, IDateTimeProvider dateTimeProvider = null)

src/Elastic.Transport/Components/NodePool/StickySniffingNodePool.cs

@@ -14,7 +14,7 @@ namespace Elastic.Transport
 	/// A connection pool implementation that supports reseeding but stays on the first <see cref="Node"/> reporting true for <see cref="Node.IsAlive"/>.
 	/// This is great if for instance you have multiple proxies that you can fallback on allowing you to seed the proxies in order of preference.
 	/// </summary>
-	public class StickySniffingNodePool : SniffingNodePool
+	public sealed class StickySniffingNodePool : SniffingNodePool
 	{
 		/// <inheritdoc cref="StickySniffingNodePool"/>
 		public StickySniffingNodePool(IEnumerable<Uri> uris, Func<Node, float> nodeScorer, IDateTimeProvider dateTimeProvider = null)

src/Elastic.Transport/Components/Pipeline/IRequestPipeline.cs

@@ -11,7 +11,7 @@
 namespace Elastic.Transport
 {
 	/// <summary> Models the workflow of a request to multiple nodes</summary>
-	public interface IRequestPipeline : IDisposable
+	public interface IRequestPipeline : IDisposable // TODO - Should we move IDisposable to the implementation / Make this an abstract base type instead?
 	{
 		//TODO should not be List but requires a refactor
 		/// <summary>

src/Elastic.Transport/Components/Pipeline/RequestData.cs

@@ -19,7 +19,7 @@ namespace Elastic.Transport
 	/// and <see cref="IRequestConfiguration" />.
 	/// </para>
 	/// </summary>
-	public class RequestData
+	public sealed class RequestData
 	{
 //TODO add xmldocs and clean up this class
 #pragma warning disable 1591

src/Elastic.Transport/Components/Providers/MemoryStreamFactory.cs

@@ -9,7 +9,7 @@ namespace Elastic.Transport
 	/// <summary>
 	/// A factory for creating memory streams using instances of <see cref="MemoryStream" />
 	/// </summary>
-	public class MemoryStreamFactory : IMemoryStreamFactory
+	public sealed class MemoryStreamFactory : IMemoryStreamFactory
 	{
 		/// <summary> Provide a static instance of this stateless class, so it can be reused</summary>
 		public static MemoryStreamFactory Default { get; } = new MemoryStreamFactory();

src/Elastic.Transport/Components/Providers/RecyclableMemoryStream.cs

@@ -315,15 +315,12 @@ protected override void Dispose(bool disposing)
 		/// Equivalent to Dispose
 		/// </summary>
 #if NETSTANDARD1_4
-        public void Close()
+        public void Close() => Dispose(true);
 #else
-		public override void Close()
+		public override void Close() => Dispose(true);
 #endif
-		{
-			Dispose(true);
-		}
 
-		#endregion
+#endregion
 
 		#region MemoryStream overrides
 

src/Elastic.Transport/Components/Providers/RecyclableMemoryStreamFactory.cs

@@ -10,7 +10,7 @@ namespace Elastic.Transport
 	/// <summary>
 	/// A factory for creating memory streams using a recyclable pool of <see cref="MemoryStream" /> instances
 	/// </summary>
-	public class RecyclableMemoryStreamFactory : IMemoryStreamFactory
+	public sealed class RecyclableMemoryStreamFactory : IMemoryStreamFactory
 	{
 		private const string TagSource = "Elastic.Transport";
 		private readonly RecyclableMemoryStreamManager _manager;

src/Elastic.Transport/Components/Providers/RecyclableMemoryStreamManager.cs

@@ -292,8 +292,7 @@ public long LargePoolInUseSize
 		/// <returns>A byte[] array</returns>
 		internal byte[] GetBlock()
 		{
-			byte[] block;
-			if (!_smallPool.TryPop(out block))
+			if (!_smallPool.TryPop(out var block))
 			{
 				// We'll add this back to the pool when the stream is disposed
 				// (unless our free pool is too large)

src/Elastic.Transport/Components/Serialization/SerializerRegistrationInformation.cs

@@ -7,7 +7,7 @@
 namespace Elastic.Transport
 {
 	/// <summary> Provides some information to the transport auditing and diagnostics infrastructure about the serializer in use and its <see cref="Purpose"/> </summary>
-	public class SerializerRegistrationInformation
+	public sealed class SerializerRegistrationInformation
 	{
 		private readonly string _stringRepresentation;