Remove MemoryStreamFactory default value from Serialize extensions (#125)

flobernd · web-flow · commit 63e90cbbe150 · 2024-10-16T13:26:06.000+02:00
This removes an ambiguity in the extension method signatures.
diff --git a/src/Elastic.Transport/Components/Serialization/TransportSerializerExtensions.cs b/src/Elastic.Transport/Components/Serialization/TransportSerializerExtensions.cs
@@ -43,7 +43,7 @@ public static byte[] SerializeToBytes<T>(
 	public static byte[] SerializeToBytes<T>(
 		this Serializer serializer,
 		T? data,
-		MemoryStreamFactory? memoryStreamFactory = null,
+		MemoryStreamFactory? memoryStreamFactory,
 		SerializationFormatting formatting = SerializationFormatting.None
 	)
 	{
@@ -82,7 +82,7 @@ public static byte[] SerializeToBytes(
 		this Serializer serializer,
 		object? data,
 		Type type,
-		MemoryStreamFactory? memoryStreamFactory = null,
+		MemoryStreamFactory? memoryStreamFactory,
 		SerializationFormatting formatting = SerializationFormatting.None
 	)
 	{
@@ -119,7 +119,7 @@ public static string SerializeToString<T>(
 	public static string SerializeToString<T>(
 		this Serializer serializer,
 		T? data,
-		MemoryStreamFactory? memoryStreamFactory = null,
+		MemoryStreamFactory? memoryStreamFactory,
 		SerializationFormatting formatting = SerializationFormatting.None
 	)
 	{
@@ -167,7 +167,7 @@ public static string SerializeToString(
 		this Serializer serializer,
 		object? data,
 		Type type,
-		MemoryStreamFactory? memoryStreamFactory = null,
+		MemoryStreamFactory? memoryStreamFactory,
 		SerializationFormatting formatting = SerializationFormatting.None
 	)
 	{
@@ -219,7 +219,7 @@ public static void Serialize<T>(
 		this Serializer serializer,
 		T? data,
 		Utf8JsonWriter writer,
-		MemoryStreamFactory? memoryStreamFactory = null,
+		MemoryStreamFactory? memoryStreamFactory,
 		SerializationFormatting formatting = SerializationFormatting.None)
 	{
 		if (serializer is SystemTextJsonSerializer stjSerializer)
@@ -279,7 +279,7 @@ public static void Serialize(
 		object? data,
 		Type type,
 		Utf8JsonWriter writer,
-		MemoryStreamFactory? memoryStreamFactory = null,
+		MemoryStreamFactory? memoryStreamFactory,
 		SerializationFormatting formatting = SerializationFormatting.None)
 	{
 		if (serializer is SystemTextJsonSerializer stjSerializer)

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public static byte[] SerializeToBytes<T>(`
`43`	`43`	`public static byte[] SerializeToBytes<T>(`
`44`	`44`	`this Serializer serializer,`
`45`	`45`	`T? data,`
`46`		`- MemoryStreamFactory? memoryStreamFactory = null,`
	`46`	`+ MemoryStreamFactory? memoryStreamFactory,`
`47`	`47`	`SerializationFormatting formatting = SerializationFormatting.None`
`48`	`48`	`)`
`49`	`49`	`{`
`@@ -82,7 +82,7 @@ public static byte[] SerializeToBytes(`
`82`	`82`	`this Serializer serializer,`
`83`	`83`	`object? data,`
`84`	`84`	`Type type,`
`85`		`- MemoryStreamFactory? memoryStreamFactory = null,`
	`85`	`+ MemoryStreamFactory? memoryStreamFactory,`
`86`	`86`	`SerializationFormatting formatting = SerializationFormatting.None`
`87`	`87`	`)`
`88`	`88`	`{`
`@@ -119,7 +119,7 @@ public static string SerializeToString<T>(`
`119`	`119`	`public static string SerializeToString<T>(`
`120`	`120`	`this Serializer serializer,`
`121`	`121`	`T? data,`
`122`		`- MemoryStreamFactory? memoryStreamFactory = null,`
	`122`	`+ MemoryStreamFactory? memoryStreamFactory,`
`123`	`123`	`SerializationFormatting formatting = SerializationFormatting.None`
`124`	`124`	`)`
`125`	`125`	`{`
`@@ -167,7 +167,7 @@ public static string SerializeToString(`
`167`	`167`	`this Serializer serializer,`
`168`	`168`	`object? data,`
`169`	`169`	`Type type,`
`170`		`- MemoryStreamFactory? memoryStreamFactory = null,`
	`170`	`+ MemoryStreamFactory? memoryStreamFactory,`
`171`	`171`	`SerializationFormatting formatting = SerializationFormatting.None`
`172`	`172`	`)`
`173`	`173`	`{`
`@@ -219,7 +219,7 @@ public static void Serialize<T>(`
`219`	`219`	`this Serializer serializer,`
`220`	`220`	`T? data,`
`221`	`221`	`Utf8JsonWriter writer,`
`222`		`- MemoryStreamFactory? memoryStreamFactory = null,`
	`222`	`+ MemoryStreamFactory? memoryStreamFactory,`
`223`	`223`	`SerializationFormatting formatting = SerializationFormatting.None)`
`224`	`224`	`{`
`225`	`225`	`if (serializer is SystemTextJsonSerializer stjSerializer)`
`@@ -279,7 +279,7 @@ public static void Serialize(`
`279`	`279`	`object? data,`
`280`	`280`	`Type type,`
`281`	`281`	`Utf8JsonWriter writer,`
`282`		`- MemoryStreamFactory? memoryStreamFactory = null,`
	`282`	`+ MemoryStreamFactory? memoryStreamFactory,`
`283`	`283`	`SerializationFormatting formatting = SerializationFormatting.None)`
`284`	`284`	`{`
`285`	`285`	`if (serializer is SystemTextJsonSerializer stjSerializer)`