Skip to content

Commit 73eeb82

Browse files
floberndflobernd
committed
Add RequestConfigurationDescriptor copy constructor
1 parent 7d3a633 commit 73eeb82

File tree

5 files changed

+99
-25
lines changed

5 files changed

+99
-25
lines changed

‎src/Elastic.Transport/Configuration/RequestConfiguration.cs‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,10 @@ public RequestConfiguration()
2929
}
3030

3131
/// <inheritdoc cref="IRequestConfiguration"/>
32-
public RequestConfiguration(IRequestConfiguration config)
32+
public RequestConfiguration(IRequestConfiguration? config)
3333
{
34-
#if NET8_0_OR_GREATER
35-
ArgumentNullException.ThrowIfNull(config);
36-
#else
3734
if (config is null)
38-
throw new ArgumentNullException(nameof(config));
39-
#endif
35+
return;
4036

4137
Accept = config.Accept;
4238
AllowedStatusCodes = config.AllowedStatusCodes;

‎src/Elastic.Transport/Configuration/TransportConfiguration.cs‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -115,14 +115,10 @@ public TransportConfiguration(
115115
}
116116

117117
/// Expert usage: Create a new transport configuration based of a previously configured instance
118-
public TransportConfiguration(ITransportConfiguration config)
118+
public TransportConfiguration(ITransportConfiguration? config)
119119
{
120-
#if NET8_0_OR_GREATER
121-
ArgumentNullException.ThrowIfNull(config);
122-
#else
123120
if (config is null)
124-
throw new ArgumentNullException(nameof(config));
125-
#endif
121+
return;
126122

127123
// it's important url formatter is repointed to the new instance of ITransportConfiguration
128124
UrlFormatter = new UrlFormatter(this);

‎src/Elastic.Transport/Configuration/TransportConfigurationDescriptor.cs‎

Lines changed: 89 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,18 @@ namespace Elastic.Transport;
2020
/// Allows you to control how <see cref="ITransport{TConfiguration}"/> behaves and where/how it connects to Elastic Stack products
2121
/// </summary>
2222
/// <remarks> <inheritdoc cref="TransportConfigurationDescriptor" path="/summary"/></remarks>
23-
/// <param name="nodePool"><inheritdoc cref="NodePool" path="/summary"/></param>
24-
/// <param name="invoker"><inheritdoc cref="IRequestInvoker" path="/summary"/></param>
25-
/// <param name="serializer"><inheritdoc cref="Serializer" path="/summary"/></param>
26-
/// <param name="productRegistration"><inheritdoc cref="ProductRegistration" path="/summary"/></param>
27-
public class TransportConfigurationDescriptor(
28-
NodePool nodePool,
29-
IRequestInvoker? invoker = null,
30-
Serializer? serializer = null,
31-
ProductRegistration? productRegistration = null) : TransportConfigurationDescriptorBase<TransportConfigurationDescriptor>(nodePool, invoker, serializer, productRegistration)
23+
public class TransportConfigurationDescriptor : TransportConfigurationDescriptorBase<TransportConfigurationDescriptor>
3224
{
25+
/// <summary>
26+
/// Creates a new instance of <see cref="TransportConfigurationDescriptor"/>
27+
/// </summary>
28+
/// <param name="nodePool"><inheritdoc cref="NodePool" path="/summary"/></param>
29+
/// <param name="invoker"><inheritdoc cref="IRequestInvoker" path="/summary"/></param>
30+
/// <param name="serializer"><inheritdoc cref="Serializer" path="/summary"/></param>
31+
/// <param name="productRegistration"><inheritdoc cref="ProductRegistration" path="/summary"/></param>
32+
public TransportConfigurationDescriptor(NodePool nodePool, IRequestInvoker? invoker = null, Serializer? serializer = null, ProductRegistration? productRegistration = null)
33+
: base(nodePool, invoker, serializer, productRegistration) { }
34+
3335
/// <summary>
3436
/// Creates a new instance of <see cref="TransportConfigurationDescriptor"/>
3537
/// </summary>
@@ -51,6 +53,15 @@ public TransportConfigurationDescriptor(string cloudId, BasicAuthentication cred
5153
/// </summary>
5254
public TransportConfigurationDescriptor(string cloudId, Base64ApiKey credentials, ProductRegistration? productRegistration = null)
5355
: this(new CloudNodePool(cloudId, credentials), productRegistration: productRegistration) { }
56+
57+
/// <summary>
58+
/// Creates a new instance of <see cref="TransportConfigurationDescriptor"/>
59+
/// <para>
60+
/// Expert usage: Create a new transport configuration based of a previously configured instance.
61+
/// </para>
62+
/// </summary>
63+
public TransportConfigurationDescriptor(ITransportConfiguration? config)
64+
: base(config) { }
5465
}
5566

5667
/// <inheritdoc cref="TransportConfigurationDescriptor"/>>
@@ -98,6 +109,75 @@ protected TransportConfigurationDescriptorBase(NodePool nodePool, IRequestInvoke
98109
_responseHeadersToParse = new HeadersList(_productRegistration.ResponseHeadersToParse);
99110
}
100111

112+
/// Expert usage: Create a new transport configuration based of a previously configured instance
113+
protected TransportConfigurationDescriptorBase(ITransportConfiguration? config)
114+
{
115+
if (config is null)
116+
return;
117+
118+
// it's important url formatter is repointed to the new instance of ITransportConfiguration
119+
_urlFormatter = new UrlFormatter(this);
120+
121+
_accept = config.Accept;
122+
_allowedStatusCodes = config.AllowedStatusCodes;
123+
_authentication = config.Authentication;
124+
_bootstrapLock = config.BootstrapLock;
125+
_certificateFingerprint = config.CertificateFingerprint;
126+
_clientCertificates = config.ClientCertificates;
127+
_connectionLimit = config.ConnectionLimit;
128+
_contentType = config.ContentType;
129+
_dateTimeProvider = config.DateTimeProvider;
130+
_deadTimeout = config.DeadTimeout;
131+
_disableAuditTrail = config.DisableAuditTrail;
132+
_disableAutomaticProxyDetection = config.DisableAutomaticProxyDetection;
133+
_disableDirectStreaming = config.DisableDirectStreaming;
134+
_disableMetaHeader = config.DisableMetaHeader;
135+
_disablePings = config.DisablePings;
136+
_disableSniff = config.DisableSniff;
137+
_dnsRefreshTimeout = config.DnsRefreshTimeout;
138+
_enableHttpCompression = config.EnableHttpCompression;
139+
_enableTcpStats = config.EnableTcpStats;
140+
_enableThreadPoolStats = config.EnableThreadPoolStats;
141+
_forceNode = config.ForceNode;
142+
_headers = config.Headers;
143+
_httpPipeliningEnabled = config.HttpPipeliningEnabled;
144+
_keepAliveInterval = config.KeepAliveInterval;
145+
_keepAliveTime = config.KeepAliveTime;
146+
_maxDeadTimeout = config.MaxDeadTimeout;
147+
_maxRetries = config.MaxRetries;
148+
_maxRetryTimeout = config.MaxRetryTimeout;
149+
_memoryStreamFactory = config.MemoryStreamFactory;
150+
_nodePool = config.NodePool;
151+
_nodePredicate = config.NodePredicate;
152+
_onRequestCompleted = config.OnRequestCompleted;
153+
_onRequestDataCreated = config.OnRequestDataCreated;
154+
_opaqueId = config.OpaqueId;
155+
_parseAllHeaders = config.ParseAllHeaders;
156+
_pingTimeout = config.PingTimeout;
157+
_pipelineProvider = config.PipelineProvider;
158+
_prettyJson = config.PrettyJson;
159+
_productRegistration = config.ProductRegistration;
160+
_proxyAddress = config.ProxyAddress;
161+
_proxyPassword = config.ProxyPassword;
162+
_proxyUsername = config.ProxyUsername;
163+
_queryStringParameters = config.QueryStringParameters;
164+
_requestInvoker = config.RequestInvoker;
165+
_requestMetaData = config.RequestMetaData;
166+
_requestResponseSerializer = config.RequestResponseSerializer;
167+
_requestTimeout = config.RequestTimeout;
168+
_responseHeadersToParse = config.ResponseHeadersToParse;
169+
_runAs = config.RunAs;
170+
_serverCertificateValidationCallback = config.ServerCertificateValidationCallback;
171+
_skipDeserializationForStatusCodes = config.SkipDeserializationForStatusCodes;
172+
_sniffInformationLifeSpan = config.SniffInformationLifeSpan;
173+
_sniffsOnConnectionFault = config.SniffsOnConnectionFault;
174+
_sniffsOnStartup = config.SniffsOnStartup;
175+
_statusCodeToResponseSuccess = config.StatusCodeToResponseSuccess;
176+
_throwExceptions = config.ThrowExceptions;
177+
_transferEncodingChunked = config.TransferEncodingChunked;
178+
_userAgent = config.UserAgent;
179+
}
180+
101181
private readonly SemaphoreSlim _bootstrapLock;
102182
private readonly NodePool _nodePool;
103183
private readonly ProductRegistration _productRegistration;

‎src/Elastic.Transport/Elastic.Transport.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<Nullable>annotations</Nullable>
1212
<IsPackable>true</IsPackable>
1313
<GenerateDocumentationFile>true</GenerateDocumentationFile>
14-
<TargetFrameworks>netstandard2.0;netstandard2.1;net462;net6.0;net8.0</TargetFrameworks>
14+
<TargetFrameworks>netstandard2.0;netstandard2.1;net462;net8.0</TargetFrameworks>
1515
</PropertyGroup>
1616

1717
<ItemGroup>
@@ -29,7 +29,7 @@
2929
</PackageReference>
3030
</ItemGroup>
3131

32-
<ItemGroup Condition="'$(TargetFramework)' != 'net6.0' And '$(TargetFramework)' != 'net8.0'">
32+
<ItemGroup Condition="'$(TargetFramework)' != 'net8.0'">
3333
<PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
3434
<PackageReference Include="System.Buffers" Version="4.5.1" />
3535
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />

‎tests/Elastic.Transport.Tests/Configuration/TransportConfigurationTests.cs‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,14 @@ public void CopiesAllProperties()
4646
autoFaker.RuleFor(x => x.ClientCertificates, f => new X509CertificateCollection());
4747

4848
var config = autoFaker.Generate();
49-
var newConfig = new TransportConfiguration(config);
50-
5149
config.Accept.Should().NotBeEmpty();
5250
config.ClientCertificates.Should().NotBeNull();
5351

52+
ITransportConfiguration newConfig = new TransportConfiguration(config);
5453
config.Should().BeEquivalentTo(newConfig);
54+
55+
ITransportConfiguration newDescriptor = new TransportConfigurationDescriptor(config);
56+
config.Should().BeEquivalentTo(newDescriptor);
5557
}
5658
#endif
5759
}

0 commit comments

Comments
 (0)