ping and sniff reuse transport requestdata

Author: Mpdreamz

src/Elastic.Transport/Components/Pipeline/DefaultRequestPipeline.cs

@@ -405,15 +405,12 @@ public async ValueTask PingCoreAsync(bool isAsync, Node node, CancellationToken
 
 		TransportResponse response;
 
-		//TODO remove
-		var requestData = new RequestData(_settings, null, null);
-
 		try
 		{
 			if (isAsync)
-				response = await _productRegistration.PingAsync(_requestInvoker, pingEndpoint, requestData, cancellationToken).ConfigureAwait(false);
+				response = await _productRegistration.PingAsync(_requestInvoker, pingEndpoint, _requestData, cancellationToken).ConfigureAwait(false);
 			else
-				response = _productRegistration.Ping(_requestInvoker, pingEndpoint, requestData);
+				response = _productRegistration.Ping(_requestInvoker, pingEndpoint, _requestData);
 
 			ThrowBadAuthPipelineExceptionWhenNeeded(response.ApiCallDetails);
 

src/Elastic.Transport/Components/Pipeline/RequestData.cs

@@ -31,11 +31,7 @@ public sealed record RequestData
 	public const string RunAsSecurityHeader = "es-security-runas-user";
 
 	/// <inheritdoc cref="RequestData"/>
-	public RequestData(
-		ITransportConfiguration global,
-		IRequestConfiguration? local,
-		CustomResponseBuilder? customResponseBuilder
-	)
+	public RequestData(ITransportConfiguration global, IRequestConfiguration? local = null, CustomResponseBuilder? customResponseBuilder = null)
 	{
 		CustomResponseBuilder = customResponseBuilder;
 		ConnectionSettings = global;

src/Elastic.Transport/Components/Providers/DefaultRequestPipelineFactory.cs

@@ -7,8 +7,7 @@ namespace Elastic.Transport;
 /// <summary>
 /// The default implementation for <see cref="RequestPipeline"/> that returns <see cref="DefaultRequestPipeline"/>
 /// </summary>
-internal sealed class DefaultRequestPipelineFactory
-	: RequestPipelineFactory
+internal sealed class DefaultRequestPipelineFactory : RequestPipelineFactory
 {
 	/// <summary>
 	/// returns instances of <see cref="DefaultRequestPipeline"/>

src/Elastic.Transport/DistributedTransport.cs

@@ -74,10 +74,10 @@ public DistributedTransport(
 
 		_productRegistration = configurationValues.ProductRegistration;
 		Configuration = configurationValues;
+		TransportRequestData = new RequestData(Configuration);
 		PipelineProvider = pipelineProvider ?? new DefaultRequestPipelineFactory();
 		DateTimeProvider = dateTimeProvider ?? DefaultDateTimeProvider.Default;
 		MemoryStreamFactory = configurationValues.MemoryStreamFactory;
-		TransportRequestData = new RequestData(Configuration, null, null);
 	}
 
 	private DateTimeProvider DateTimeProvider { get; }

tests/Elastic.Transport.Tests/Configuration/TransportConfigurationTests.cs

@@ -9,7 +9,6 @@
 using Xunit;
 #if !NETFRAMEWORK
 using Soenneker.Utils.AutoBogus;
-using Soenneker.Utils.AutoBogus.Config;
 #endif
 
 namespace Elastic.Transport.Tests.Configuration;