Rename ErrorSerializerContext and update related references (#164)

Mpdreamz · web-flow · commit eeed2ad83867 · 2025-05-20T12:45:27.000+02:00
Renamed `ErrorSerializerContext` to
`ElasticsearchTransportSerializerContext` for improved clarity and
consistency. Updated all references across serialization logic and tests
to align with the new context name. This ensures correct deserialization
behavior and avoids potential conflicts with outdated naming.
diff --git a/Playground/Program.cs b/Playground/Program.cs
@@ -23,6 +23,10 @@
 var dynamicResponse = transport.Request<DynamicResponse>(HttpMethod.GET, "/");
 Console.WriteLine(dynamicResponse.Body.Get<string>("version.build_flavor"));
 
+var body = PostData.String("{\"name\": \"test\"}");
+var indexResponse = transport.Request<EsResponse>(HttpMethod.POST, "/does-not-exist/_doc", body);
+Console.WriteLine(indexResponse.DebugInformation);
+
 Console.WriteLine(registration.DefaultContentType ?? "NOT SPECIFIED");
 
 public class EsResponse : ElasticsearchResponse;
diff --git a/src/Elastic.Transport/Components/Serialization/Converters/DynamicDictionaryConverter.cs b/src/Elastic.Transport/Components/Serialization/Converters/DynamicDictionaryConverter.cs
@@ -19,15 +19,15 @@ public override DynamicDictionary Read(ref Utf8JsonReader reader, Type typeToCon
 	{
 		if (reader.TokenType == JsonTokenType.StartArray)
 		{
-			var array = JsonSerializer.Deserialize<object[]>(ref reader, ErrorSerializerContext.Default.ObjectArray); // TODO: Test! This might not work without adding `object[]` to `ErrorSerializationContext`
+			var array = JsonSerializer.Deserialize<object[]>(ref reader, ElasticsearchTransportSerializerContext.Default.ObjectArray); // TODO: Test! This might not work without adding `object[]` to `ErrorSerializationContext`
 			var arrayDict = new Dictionary<string, object>();
 			for (var i = 0; i < array.Length; i++)
 				arrayDict[i.ToString(CultureInfo.InvariantCulture)] = new DynamicValue(array[i]);
 			return DynamicDictionary.Create(arrayDict);
 		}
 		if (reader.TokenType != JsonTokenType.StartObject) throw new JsonException();
 
-		var dict = JsonSerializer.Deserialize<Dictionary<string, object>>(ref reader, ErrorSerializerContext.Default.DictionaryStringObject); // TODO: Test! This might not work without adding `Dictionary<string, object>` to `ErrorSerializationContext`
+		var dict = JsonSerializer.Deserialize<Dictionary<string, object>>(ref reader, ElasticsearchTransportSerializerContext.Default.DictionaryStringObject); // TODO: Test! This might not work without adding `Dictionary<string, object>` to `ErrorSerializationContext`
 		return DynamicDictionary.Create(dict);
 	}
 
diff --git a/src/Elastic.Transport/Components/Serialization/Converters/ExceptionConverter.cs b/src/Elastic.Transport/Components/Serialization/Converters/ExceptionConverter.cs
@@ -72,7 +72,7 @@ public override void Write(Utf8JsonWriter writer, Exception value, JsonSerialize
 			foreach (var kv in flattenedException)
 			{
 				writer.WritePropertyName(kv.Key);
-				JsonSerializer.Serialize(writer, kv.Value, ErrorSerializerContext.Default.Object); // TODO: Test! This might not work without adding `KeyValuePair<string, object>` to `ErrorSerializationContext`
+				JsonSerializer.Serialize(writer, kv.Value, ElasticsearchTransportSerializerContext.Default.Object); // TODO: Test! This might not work without adding `KeyValuePair<string, object>` to `ErrorSerializationContext`
 			}
 			writer.WriteEndObject();
 		}
diff --git a/src/Elastic.Transport/Components/Serialization/LowLevelRequestResponseSerializer.cs b/src/Elastic.Transport/Components/Serialization/LowLevelRequestResponseSerializer.cs
@@ -38,7 +38,7 @@ public LowLevelRequestResponseSerializer(IReadOnlyCollection<JsonConverter>? con
 		{
 			options.DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull;
 #pragma warning disable IL2026, IL3050
-			options.TypeInfoResolver = JsonTypeInfoResolver.Combine(new DefaultJsonTypeInfoResolver(), ErrorSerializerContext.Default);
+			options.TypeInfoResolver = JsonTypeInfoResolver.Combine(new DefaultJsonTypeInfoResolver(), ElasticsearchTransportSerializerContext.Default);
 #pragma warning restore IL2026, IL3050
 		})) { }
 
diff --git a/src/Elastic.Transport/Products/Elasticsearch/ErrorSerializationContext.cs b/src/Elastic.Transport/Products/Elasticsearch/ErrorSerializationContext.cs
@@ -21,4 +21,4 @@ namespace Elastic.Transport.Products.Elasticsearch;
 [JsonSerializable(typeof(IReadOnlyDictionary<string, string>))]
 [JsonSerializable(typeof(string))]
 [JsonSourceGenerationOptions(GenerationMode = JsonSourceGenerationMode.Default, UseStringEnumConverter = true)]
-public partial class ErrorSerializerContext : JsonSerializerContext;
+public partial class ElasticsearchTransportSerializerContext : JsonSerializerContext;
diff --git a/src/Elastic.Transport/Products/Elasticsearch/Failures/Error.cs b/src/Elastic.Transport/Products/Elasticsearch/Failures/Error.cs
@@ -52,14 +52,14 @@ public override Error Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe
 
 				if (reader.ValueTextEquals("root_cause"))
 				{
-					var value = JsonSerializer.Deserialize<IReadOnlyCollection<ErrorCause>>(ref reader, ErrorSerializerContext.Default.IReadOnlyCollectionErrorCause);
+					var value = JsonSerializer.Deserialize<IReadOnlyCollection<ErrorCause>>(ref reader, ElasticsearchTransportSerializerContext.Default.IReadOnlyCollectionErrorCause);
 					error.RootCause = value;
 					continue;
 				}
 
 				if (reader.ValueTextEquals("caused_by"))
 				{
-					var value = JsonSerializer.Deserialize<ErrorCause>(ref reader, ErrorSerializerContext.Default.ErrorCause);
+					var value = JsonSerializer.Deserialize<ErrorCause>(ref reader, ElasticsearchTransportSerializerContext.Default.ErrorCause);
 					error.CausedBy = value;
 					continue;
 				}
@@ -73,49 +73,49 @@ public override Error Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe
 
 				if (reader.ValueTextEquals("headers"))
 				{
-					var value = JsonSerializer.Deserialize<IReadOnlyDictionary<string, string>>(ref reader, ErrorSerializerContext.Default.IReadOnlyDictionaryStringString); // TODO: Test! This might not work without adding `IReadOnlyDictionary<string, string>` to `ErrorSerializationContext`
+					var value = JsonSerializer.Deserialize<IReadOnlyDictionary<string, string>>(ref reader, ElasticsearchTransportSerializerContext.Default.IReadOnlyDictionaryStringString); // TODO: Test! This might not work without adding `IReadOnlyDictionary<string, string>` to `ErrorSerializationContext`
 					error.Headers = value;
 					continue;
 				}
 
 				if (reader.ValueTextEquals("stack_trace"))
 				{
-					var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);
+					var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);
 					error.StackTrace = value;
 					continue;
 				}
 
 				if (reader.ValueTextEquals("type"))
 				{
-					var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);
+					var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);
 					error.Type = value;
 					continue;
 				}
 
 				if (reader.ValueTextEquals("index"))
 				{
-					var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);
+					var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);
 					error.Index = value;
 					continue;
 				}
 
 				if (reader.ValueTextEquals("index_uuid"))
 				{
-					var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);
+					var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);
 					error.IndexUUID = value;
 					continue;
 				}
 
 				if (reader.ValueTextEquals("reason"))
 				{
-					var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);
+					var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);
 					error.Reason = value;
 					continue;
 				}
 
 				additional ??= new Dictionary<string, object>();
 				var key = reader.GetString();
-				var additionaValue = JsonSerializer.Deserialize<object>(ref reader, ErrorSerializerContext.Default.Object);
+				var additionaValue = JsonSerializer.Deserialize<object>(ref reader, ElasticsearchTransportSerializerContext.Default.Object);
 				additional.Add(key, additionaValue);
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -19,15 +19,15 @@ public override DynamicDictionary Read(ref Utf8JsonReader reader, Type typeToCon`
`19`	`19`	`{`
`20`	`20`	`if (reader.TokenType == JsonTokenType.StartArray)`
`21`	`21`	`{`
`22`		- var array = JsonSerializer.Deserialize<object[]>(ref reader, ErrorSerializerContext.Default.ObjectArray); // TODO: Test! This might not work without adding `object[]` to `ErrorSerializationContext`
	`22`	+ var array = JsonSerializer.Deserialize<object[]>(ref reader, ElasticsearchTransportSerializerContext.Default.ObjectArray); // TODO: Test! This might not work without adding `object[]` to `ErrorSerializationContext`
`23`	`23`	`var arrayDict = new Dictionary<string, object>();`
`24`	`24`	`for (var i = 0; i < array.Length; i++)`
`25`	`25`	`arrayDict[i.ToString(CultureInfo.InvariantCulture)] = new DynamicValue(array[i]);`
`26`	`26`	`return DynamicDictionary.Create(arrayDict);`
`27`	`27`	`}`
`28`	`28`	`if (reader.TokenType != JsonTokenType.StartObject) throw new JsonException();`
`29`	`29`
`30`		- var dict = JsonSerializer.Deserialize<Dictionary<string, object>>(ref reader, ErrorSerializerContext.Default.DictionaryStringObject); // TODO: Test! This might not work without adding `Dictionary<string, object>` to `ErrorSerializationContext`
	`30`	+ var dict = JsonSerializer.Deserialize<Dictionary<string, object>>(ref reader, ElasticsearchTransportSerializerContext.Default.DictionaryStringObject); // TODO: Test! This might not work without adding `Dictionary<string, object>` to `ErrorSerializationContext`
`31`	`31`	`return DynamicDictionary.Create(dict);`
`32`	`32`	`}`
`33`	`33`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public override void Write(Utf8JsonWriter writer, Exception value, JsonSerialize`
`72`	`72`	`foreach (var kv in flattenedException)`
`73`	`73`	`{`
`74`	`74`	`writer.WritePropertyName(kv.Key);`
`75`		- JsonSerializer.Serialize(writer, kv.Value, ErrorSerializerContext.Default.Object); // TODO: Test! This might not work without adding `KeyValuePair<string, object>` to `ErrorSerializationContext`
	`75`	+ JsonSerializer.Serialize(writer, kv.Value, ElasticsearchTransportSerializerContext.Default.Object); // TODO: Test! This might not work without adding `KeyValuePair<string, object>` to `ErrorSerializationContext`
`76`	`76`	`}`
`77`	`77`	`writer.WriteEndObject();`
`78`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public LowLevelRequestResponseSerializer(IReadOnlyCollection<JsonConverter>? con`
`38`	`38`	`{`
`39`	`39`	`options.DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull;`
`40`	`40`	`#pragma warning disable IL2026, IL3050`
`41`		`- options.TypeInfoResolver = JsonTypeInfoResolver.Combine(new DefaultJsonTypeInfoResolver(), ErrorSerializerContext.Default);`
	`41`	`+ options.TypeInfoResolver = JsonTypeInfoResolver.Combine(new DefaultJsonTypeInfoResolver(), ElasticsearchTransportSerializerContext.Default);`
`42`	`42`	`#pragma warning restore IL2026, IL3050`
`43`	`43`	`})) { }`
`44`	`44`
Original file line number	Diff line number	Diff line change
`@@ -52,14 +52,14 @@ public override Error Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe`
`52`	`52`
`53`	`53`	`if (reader.ValueTextEquals("root_cause"))`
`54`	`54`	`{`
`55`		`- var value = JsonSerializer.Deserialize<IReadOnlyCollection<ErrorCause>>(ref reader, ErrorSerializerContext.Default.IReadOnlyCollectionErrorCause);`
	`55`	`+ var value = JsonSerializer.Deserialize<IReadOnlyCollection<ErrorCause>>(ref reader, ElasticsearchTransportSerializerContext.Default.IReadOnlyCollectionErrorCause);`
`56`	`56`	`error.RootCause = value;`
`57`	`57`	`continue;`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`if (reader.ValueTextEquals("caused_by"))`
`61`	`61`	`{`
`62`		`- var value = JsonSerializer.Deserialize<ErrorCause>(ref reader, ErrorSerializerContext.Default.ErrorCause);`
	`62`	`+ var value = JsonSerializer.Deserialize<ErrorCause>(ref reader, ElasticsearchTransportSerializerContext.Default.ErrorCause);`
`63`	`63`	`error.CausedBy = value;`
`64`	`64`	`continue;`
`65`	`65`	`}`
`@@ -73,49 +73,49 @@ public override Error Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSe`
`73`	`73`
`74`	`74`	`if (reader.ValueTextEquals("headers"))`
`75`	`75`	`{`
`76`		- var value = JsonSerializer.Deserialize<IReadOnlyDictionary<string, string>>(ref reader, ErrorSerializerContext.Default.IReadOnlyDictionaryStringString); // TODO: Test! This might not work without adding `IReadOnlyDictionary<string, string>` to `ErrorSerializationContext`
	`76`	+ var value = JsonSerializer.Deserialize<IReadOnlyDictionary<string, string>>(ref reader, ElasticsearchTransportSerializerContext.Default.IReadOnlyDictionaryStringString); // TODO: Test! This might not work without adding `IReadOnlyDictionary<string, string>` to `ErrorSerializationContext`
`77`	`77`	`error.Headers = value;`
`78`	`78`	`continue;`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`if (reader.ValueTextEquals("stack_trace"))`
`82`	`82`	`{`
`83`		`- var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);`
	`83`	`+ var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);`
`84`	`84`	`error.StackTrace = value;`
`85`	`85`	`continue;`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`if (reader.ValueTextEquals("type"))`
`89`	`89`	`{`
`90`		`- var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);`
	`90`	`+ var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);`
`91`	`91`	`error.Type = value;`
`92`	`92`	`continue;`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`if (reader.ValueTextEquals("index"))`
`96`	`96`	`{`
`97`		`- var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);`
	`97`	`+ var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);`
`98`	`98`	`error.Index = value;`
`99`	`99`	`continue;`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`if (reader.ValueTextEquals("index_uuid"))`
`103`	`103`	`{`
`104`		`- var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);`
	`104`	`+ var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);`
`105`	`105`	`error.IndexUUID = value;`
`106`	`106`	`continue;`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`if (reader.ValueTextEquals("reason"))`
`110`	`110`	`{`
`111`		`- var value = JsonSerializer.Deserialize<string>(ref reader, ErrorSerializerContext.Default.String);`
	`111`	`+ var value = JsonSerializer.Deserialize<string>(ref reader, ElasticsearchTransportSerializerContext.Default.String);`
`112`	`112`	`error.Reason = value;`
`113`	`113`	`continue;`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`additional ??= new Dictionary<string, object>();`
`117`	`117`	`var key = reader.GetString();`
`118`		`- var additionaValue = JsonSerializer.Deserialize<object>(ref reader, ErrorSerializerContext.Default.Object);`
	`118`	`+ var additionaValue = JsonSerializer.Deserialize<object>(ref reader, ElasticsearchTransportSerializerContext.Default.Object);`
`119`	`119`	`additional.Add(key, additionaValue);`
`120`	`120`	`}`
`121`	`121`