Only call CreateJsonSerializerOptions once

Author: flobernd

src/Elastic.Transport/Components/Serialization/IJsonSerializerOptionsProvider.cs

@@ -17,9 +17,10 @@ public interface IJsonSerializerOptionsProvider
 	/// <inheritdoc cref="IJsonSerializerOptionsProvider"/>
 	JsonSerializerOptions CreateJsonSerializerOptions();
 }
+
 /// <summary>
 /// Default implementation of <see cref="IJsonSerializerOptionsProvider"/> specialized in providing more converters and
-/// altering the shared <see cref="JsonSerializerOptions"/> used by <see cref="SystemTextJsonSerializer"/> and its derrived classes
+/// altering the shared <see cref="JsonSerializerOptions"/> used by <see cref="SystemTextJsonSerializer"/> and its derived classes
 /// </summary>
 public class TransportSerializerOptionsProvider : IJsonSerializerOptionsProvider
 {
@@ -31,6 +32,7 @@ public class TransportSerializerOptionsProvider : IJsonSerializerOptionsProvider
 	public JsonSerializerOptions? CreateJsonSerializerOptions()
 	{
 		var options = new JsonSerializerOptions();
+
 		foreach (var converter in _bakedInConverters ?? [])
 			options.Converters.Add(converter);
 
@@ -57,4 +59,3 @@ public TransportSerializerOptionsProvider(
 		_mutateOptions = mutateOptions;
 	}
 }
-

src/Elastic.Transport/Components/Serialization/SystemTextJsonSerializer.cs

@@ -27,11 +27,12 @@ public abstract class SystemTextJsonSerializer : Serializer
 	/// </summary>
 	protected SystemTextJsonSerializer(IJsonSerializerOptionsProvider? provider = null)
 	{
-
 		provider ??= new TransportSerializerOptionsProvider();
 		_options = provider.CreateJsonSerializerOptions();
-		_indentedOptions = provider.CreateJsonSerializerOptions();
-		_indentedOptions.WriteIndented = true;
+		_indentedOptions = new JsonSerializerOptions(_options)
+		{
+			WriteIndented = true
+		};
 	}
 
 	#region Serializer
@@ -93,7 +94,6 @@ public override Task SerializeAsync<T>(T data, Stream stream,
 	protected internal JsonSerializerOptions? GetJsonSerializerOptions(SerializationFormatting formatting = SerializationFormatting.None) =>
 		formatting is SerializationFormatting.None ? _options : _indentedOptions;
 
-
 	private static bool TryReturnDefault<T>(Stream? stream, out T deserialize)
 	{
 		deserialize = default;