Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is including tap files into the npm bundles intentional? #2483

Closed
Marsup opened this issue Nov 20, 2024 · 1 comment · Fixed by #2487
Closed

Is including tap files into the npm bundles intentional? #2483

Marsup opened this issue Nov 20, 2024 · 1 comment · Fixed by #2487

Comments

@Marsup
Copy link

Marsup commented Nov 20, 2024

Question

Hi,

I guess the title says it all, but the .tap folder has been included in the npm packages (and it's fairly big) since 8.15.2.
I intended to propose a patch to add this folder to .gitignore, but probably a developer would have seen it locally, so maybe that's intentional?

Thanks.

@JoshMock
Copy link
Member

It's not intentional! Thanks for catching that. Fixed in #2487 and will be publishing 8.15.3 and 8.16.2 with the correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants