-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The PUT connector should have connector_id as optional? #2715
Comments
cc @jedrazb |
I just tried with Elasticsearch 8.14.3 and it seems the
This means we should remove the path |
I just sent this PR to fix the rest-api-spec of Elasticsearch. |
Hey @ezimuel Thank you for reporting this issue. Since other PUT endpoints in ES generally expect a given resource ID (rather than auto-generating one) when creating a resource, I believe we should adhere to this pattern in the connector API and always expect an ID path param for There appears to be one failing unit test due to validation logic. Let me fix that! I will include the necessary changes to the client spec as a part of this PR: #2675 |
Reading the specification of
connector.put
endpoint that has 2 URL:/_connector/{connector_id}
/_connector
It appears the
connector_id
should be optional but it's required right now.Moreover, reading the documentation it seems the
connector_id
is required and there's no mention about thePUT /_connector
URL.The text was updated successfully, but these errors were encountered: