Skip to content

[validation] Check if "@non_exhaustive" is supported correctly #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
l-trotta opened this issue Feb 6, 2025 · 0 comments
Open

[validation] Check if "@non_exhaustive" is supported correctly #3731

l-trotta opened this issue Feb 6, 2025 · 0 comments
Labels
spec validation

Comments

@l-trotta
Copy link
Contributor

l-trotta commented Feb 6, 2025

Running make validate api=simulate.ingest branch=main returns the following error:

Type '{ "non-existent-processor": {}; }' is not assignable to type 'IngestProcessorContainer'.
  Object literal may only specify known properties, and '"non-existent-processor"' does not exist in type 'IngestProcessorContainer'.

The relevant failing test is actually valid, because ProcessorContainer is tagged with:

/**
 * @variants container
 * @non_exhaustive
 */

so it should allow an unknown value. Does validation consider @non_exhaustive?.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@l-trotta