update logic for x-metatags to use the standard term used by webteam … #4972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@l-trotta, @szabosteve , and @lcawl making a minor update to what we just created for the product facets. This will align with what we currently have for docs and the webteam for search. This is related to #4511 |
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
updating the friendly names as bump logic does not convert product ID to product Name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the new x-metatags logic implemented to update the name. The web team and docs are already leveraging product_name for facets. The current implementation converts the key value pair in the x-metatags area to a head element in the HTML. By changing to product_name this will work as expected with currently workflows with docs and the web team for site search.