Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Autoscaling issue when context.currentCapacity() is null #116384

Open
qherreros opened this issue Nov 7, 2024 · 1 comment
Open

[ML] Autoscaling issue when context.currentCapacity() is null #116384

qherreros opened this issue Nov 7, 2024 · 1 comment
Assignees
Labels
>bug :ml Machine learning Team:ML Meta label for the ML team

Comments

@qherreros
Copy link

Elasticsearch Version

7.17.24

Installed Plugins

No response

Java Version

bundled

OS Version

N/A

Problem Description

In MlMemoryAutoscalingDecider.java:

                MlMemoryAutoscalingCapacity capacity = ensureScaleDown(
                    result,
                    MlMemoryAutoscalingCapacity.from(context.currentCapacity()).build()
                );

the call context.currentCapacity() may result in null (see JavaDoc)

    /**
     * Return current capacity of nodes governed by the policy. Can be null if the capacity of some nodes is unavailable. If a decider
     * relies on this value and gets a null current capacity, it should return a result with a null requiredCapacity (undecided).
     */
    AutoscalingCapacity currentCapacity();

However MlMemoryAutoscalingCapacity.from(null) crashes.

Steps to Reproduce

N/A

Logs (if relevant)

No response

@qherreros qherreros added :ml Machine learning >bug labels Nov 7, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml Machine learning Team:ML Meta label for the ML team
Projects
None yet
Development

No branches or pull requests

3 participants