Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES|QL: Fix funciton Telemetry tests #116470

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ES|QL: Fix funciton Telemetry tests #116470

wants to merge 4 commits into from

Conversation

luigidellaquila
Copy link
Contributor

@luigidellaquila luigidellaquila commented Nov 8, 2024 •
edited
Loading

Wrong update of the number of snapshot functions from #115792

Fixes: #115231
Fixes: #116448
Fixes: #116462
Fixes: #116463
Fixes: #116464
Fixes: #116465

@luigidellaquila luigidellaquila added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.17.0 labels Nov 8, 2024
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v10.0.0 labels Nov 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@astefan astefan added the test-release Trigger CI checks against release build label Nov 8, 2024
@breskeby breskeby added v9.0.0 and removed v10.0.0 labels Nov 8, 2024
@luigidellaquila luigidellaquila mentioned this pull request Nov 8, 2024
Open
ivancea
ivancea approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@ivancea ivancea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! How did this pass the CI, or why is this failing now?

@luigidellaquila
Copy link
Contributor Author

It only fails on release tests (ie. non-snapshot), the test is excluded in normal builds.
The final reason is that we see a different number of functions in Snapshot vs. non-Snapshot, so we need two tests that only run in specific configurations.
To see the failure on a PR, you have to label it test-release

@luigidellaquila luigidellaquila enabled auto-merge (squash) November 8, 2024 12:05
@luigidellaquila
Copy link
Contributor Author

KqlQueryBuilderTests failing, completely unrelated

@luigidellaquila
Copy link
Contributor Author

@elasticmachine update branch

@luigidellaquila
Copy link
Contributor Author

@elasticmachine update branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivancea ivancea ivancea approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
6 participants
@luigidellaquila @elasticsearchmachine @ivancea @breskeby @astefan @elasticmachine