-
Notifications
You must be signed in to change notification settings - Fork 861
Open
Description
The purpose of this issue is to move our internally defined ESLint rules to our ESLint plugin. The goal is for consumers to be able to reuse useful warnings, e.g. css_logical_properties.
These rules are defined in: packages/eui/scripts/eslint-plugin
Acceptance criteria
- all internally defined rules are moved to
packages/eslint-plugin:packages/eui/scripts/eslint-plugin/css_logical_properties.js(in recommended)packages/eui/scripts/eslint-plugin/forward_ref_display_name.jspackages/eui/scripts/eslint-plugin/i18n.jspackages/eui/scripts/eslint-plugin/rel.js(in recommended)packages/eui/scripts/eslint-plugin/require_cypress_references.jspackages/eui/scripts/eslint-plugin/require_license_header.js
- only define rules in recommended if they make sense to be reused by consumers,
- rules like
i18nandrelare renamed for clarity, the name should suggest the rule, - if needed, rules are broken down into smaller ones,
- changes are tested in Kibana.
Metadata
Metadata
Assignees
Labels
No labels