Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version reference in Dockerfile for E2E tests #3886

Closed
ycombinator opened this issue Sep 10, 2024 · 1 comment · Fixed by #3889
Closed

Fix version reference in Dockerfile for E2E tests #3886

ycombinator opened this issue Sep 10, 2024 · 1 comment · Fixed by #3889
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ycombinator
Copy link
Contributor

In the Dockerfile used for E2E tests, there are two commands that copy the built Fleet Server artifact into the appropriate Agent components folder:

ONBUILD COPY --chmod=0755 --chown=elastic-agent cover/fleet-server-${STACK_VERSION}-linux-x86_64/fleet-server \
./data/elastic-agent-${VCS_REF_SHORT}/components/fleet-server

ONBUILD COPY --chmod=0755 --chown=elastic-agent cover/fleet-server-${STACK_VERSION}-linux-arm64/fleet-server \
./data/elastic-agent-${VCS_REF_SHORT}/components/fleet-server

The value of ${STACK_VERSION} mentioned in these commands should be the version of the built Fleet Server artifact, which should be the same as:

const DefaultVersion = "9.0.0"

However, this isn't always the case, e.g. #3857 (comment)

We should fix this reference to contain the correct version value.

@ycombinator ycombinator added the bug Something isn't working label Sep 10, 2024
@ycombinator
Copy link
Contributor Author

cc: @michel-laterman per our 1-1 discussion today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant