update backend validation to use prefix and add integration tests

Author: couvq

x-pack/platform/plugins/shared/streams/server/lib/streams/client.ts

@@ -34,7 +34,6 @@ import { State } from './state_management/state';
 import { checkAccess, checkAccessBulk } from './stream_crud';
 import { StreamsStatusConflictError } from './errors/streams_status_conflict_error';
 import type { FeatureClient } from './feature/feature_client';
-
 interface AcknowledgeResponse<TResult extends Result> {
   acknowledged: true;
   result: TResult;
@@ -324,13 +323,11 @@ export class StreamsClient {
       throw new StatusError(`Child stream ${name} already exists`, 409);
     }
 
-    // TODO - These constants need to be shared between both plugins so I don't have to duplicate them
-    // TODO: need to know prefix to do min check properly
-    logger.info(`parent: ${parent}, \n name: ${name}`);
-    const MIN_NAME_LENGTH = 6; // 'logs.' is already included which is 5 characters, so user must enter at least one more.
+    const prefix = parent + '.';
+    // TODO - constants need to be shared between both plugins so we don't have to duplicate them
     const MAX_NAME_LENGTH = 200;
 
-    if (name.length < MIN_NAME_LENGTH) {
+    if (name.length <= prefix.length) {
       throw new StatusError('Stream name must not be empty.', 400);
     }
 

x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_routing/stream_name_form_row.tsx

@@ -30,6 +30,7 @@ const MIN_NAME_LENGTH = 1;
 const MAX_NAME_LENGTH = 200;
 const PREFIX_MAX_VISIBLE_CHARACTERS = 25;
 
+// TODO: write a unit test for this function
 const getHelpText = (prefix: string, value: string, readOnly: boolean): string | undefined => {
   if (value.length <= prefix.length && !readOnly) {
     return i18n.translate('xpack.streams.streamDetailRouting.emptyNameErrorHelpText', {

x-pack/platform/test/api_integration_deployment_agnostic/apis/streams/basic.ts

@@ -246,6 +246,40 @@ export default function ({ getService }: DeploymentAgnosticFtrProviderContext) {
         expect(response).to.have.property('message', 'Child stream logs.nginx already exists');
       });
 
+      it('fails to fork logs with empty stream name', async () => {
+        const body = {
+          stream: {
+            name: 'logs.', // empty child stream name
+          },
+          where: {
+            field: 'log.logger',
+            eq: 'nginx',
+          },
+          status,
+        };
+        const response = await forkStream(apiClient, 'logs', body, 400);
+        expect(response).to.have.property('message', 'Stream name must not be empty.');
+      });
+
+      it('fails to fork logs with stream name that is over the 200 character limit', async () => {
+        const body = {
+          stream: {
+            // child stream is 201 chars
+            name: 'logs.xwdaqmsegtkamcrofcfcomnlkkkrkqtlkbqizvjvtrbwereqygqaaxmodzccqipzpwymyowrtvljtxevczoohrbpgijilsdptszgssmrkpwhvkukkgiqhvmcuzygmolyyadbxwngbkqjkretmzhgntkjkhrmltgyurufizwlelvmaqtngwhwqhxpfsuxiivxspvtwfcem',
+          },
+          where: {
+            field: 'log.logger',
+            eq: 'nginx',
+          },
+          status,
+        };
+        const response = await forkStream(apiClient, 'logs', body, 400);
+        expect(response).to.have.property(
+          'message',
+          'Stream name cannot be longer than 200 characters.'
+        );
+      });
+
       it('Index an Nginx access log message, should goto logs.nginx', async () => {
         const doc = {
           '@timestamp': '2024-01-01T00:00:10.000Z',