[Observability] Add View in discover button in alert details page for SLO burn rate and ES query rules (#233855)

This PR is part of issue
#230058.

For the ES query rule I'm using the link that is returned in the alert
document. The logic to create the link is quite complicated and hard to
extract from the rule executor so I thought it would be easier this way.
One downside of this is that we cannot set our own time range.

For the SLO burn rate rule I've added the data view id to the alert
document so that I can create the discover app params using that in the
FE.




https://github.com/user-attachments/assets/b443e652-584d-478c-b052-23436dfa0404

---------

Co-authored-by: Copilot <[email protected]>

Author: 2 people

src/platform/packages/shared/kbn-alerts-as-data-utils/src/schemas/create_schema_from_field_map.ts

@@ -347,6 +347,13 @@ const getSchemaFileContents = (lineWriters: Record<string, LineWriter>, schemaPr
 const writeGeneratedFile = (fileName: string, contents: string) => {
   const genFileName = path.join(PLUGIN_DIR, fileName);
   try {
+    // Check if file exists and content is the same
+    if (fs.existsSync(genFileName)) {
+      const existingContent = fs.readFileSync(genFileName, 'utf8');
+      if (existingContent === contents) {
+        return;
+      }
+    }
     fs.writeFileSync(genFileName, contents);
   } catch (err) {
     logError(`error writing file: ${genFileName}: ${err.message}`);

src/platform/packages/shared/kbn-alerts-as-data-utils/src/schemas/generated/observability_slo_schema.ts

@@ -84,6 +84,7 @@ const ObservabilitySloAlertOptional = rt.partial({
     })
   ),
   'kibana.alert.grouping': schemaUnknown,
+  'slo.dataViewId': schemaString,
   'slo.id': schemaString,
   'slo.instanceId': schemaString,
   'slo.revision': schemaStringOrNumber,

x-pack/platform/plugins/shared/alerting/server/integration_tests/__snapshots__/alert_as_data_fields.test.ts.snap

@@ -0,0 +1,60 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import type { CustomThresholdParams } from '@kbn/response-ops-rule-params/custom_threshold';
+import type { Rule } from '@kbn/alerts-ui-shared';
+import type { Filter } from '@kbn/es-query';
+import {
+  FilterStateStore,
+  buildCustomFilter,
+  fromKueryExpression,
+  toElasticsearchQuery,
+} from '@kbn/es-query';
+import type { DataViewSpec } from '@kbn/data-views-plugin/common';
+import { getViewInAppLocatorParams } from '../../../../../../common/custom_threshold_rule/get_view_in_app_url';
+
+export const getCustomThresholdRuleData = ({ rule }: { rule: Rule }) => {
+  const ruleParams = rule.params as CustomThresholdParams;
+  const { index } = ruleParams.searchConfiguration;
+  let dataViewId: string | undefined;
+  if (typeof index === 'string') {
+    dataViewId = index;
+  } else if (index) {
+    dataViewId = index.title;
+  }
+
+  const filters = ruleParams.criteria
+    .flatMap(({ metrics }) =>
+      metrics.map((metric) => {
+        return metric.filter && dataViewId
+          ? buildCustomFilter(
+              dataViewId,
+              toElasticsearchQuery(fromKueryExpression(metric.filter)),
+              true,
+              false,
+              null,
+              FilterStateStore.APP_STATE
+            )
+          : undefined;
+      })
+    )
+    .filter((f): f is Filter => f !== undefined);
+
+  return {
+    discoverAppLocatorParams: {
+      ...getViewInAppLocatorParams({
+        dataViewId,
+        searchConfiguration: {
+          index: ruleParams.searchConfiguration.index as DataViewSpec | string,
+          query: ruleParams.searchConfiguration.query,
+          filter: ruleParams.searchConfiguration.filter,
+        },
+      }),
+      filters,
+    },
+  };
+};

x-pack/solutions/observability/plugins/observability/public/pages/alert_details/hooks/use_discover_url/get_rule_data/custom_threshold_rule.ts

@@ -0,0 +1,15 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { ALERT_URL } from '@kbn/rule-data-utils';
+import type { TopAlert } from '../../../../../typings/alerts';
+
+export const getEsQueryRuleData = ({ alert }: { alert: TopAlert }) => {
+  const discoverUrl = alert.fields[ALERT_URL];
+
+  return discoverUrl ? { discoverUrl } : {};
+};

x-pack/solutions/observability/plugins/observability/public/pages/alert_details/hooks/use_discover_url/get_rule_data/es_query_rule.ts

@@ -0,0 +1,10 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+export { getCustomThresholdRuleData } from './custom_threshold_rule';
+export { getEsQueryRuleData } from './es_query_rule';
+export { getSLOBurnRateRuleData } from './slo_burn_rate_rule';

x-pack/solutions/observability/plugins/observability/public/pages/alert_details/hooks/use_discover_url/get_rule_data/index.ts

@@ -0,0 +1,14 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import type { TopAlert } from '../../../../../typings/alerts';
+
+export const getSLOBurnRateRuleData = ({ alert }: { alert: TopAlert }) => {
+  const dataViewId = 'slo.dataViewId' in alert.fields ? alert.fields['slo.dataViewId'] : undefined;
+
+  return typeof dataViewId === 'string' ? { discoverAppLocatorParams: { dataViewId } } : {};
+};

x-pack/solutions/observability/plugins/observability/public/pages/alert_details/hooks/use_discover_url/get_rule_data/slo_burn_rate_rule.ts

@@ -13,6 +13,8 @@ import {
   OBSERVABILITY_THRESHOLD_RULE_TYPE_ID,
   SYNTHETICS_STATUS_RULE,
   SYNTHETICS_TLS_RULE,
+  ES_QUERY_ID,
+  SLO_BURN_RATE_RULE_TYPE_ID,
 } from '@kbn/rule-data-utils';
 import type { Rule } from '@kbn/alerts-ui-shared';
 import type { TopAlert } from '../../../../typings/alerts';
@@ -173,6 +175,94 @@ describe('useDiscoverUrl', () => {
     });
   });
 
+  it('returns the discover URL from alert for ES query rule', () => {
+    const expectedDiscoverUrl = '/app/discover#/view/some-saved-search';
+    const alertWithUrl = {
+      ...MOCK_ALERT,
+      fields: {
+        'kibana.alert.url': expectedDiscoverUrl,
+      },
+    } as unknown as TopAlert;
+
+    const rule = {
+      ruleTypeId: ES_QUERY_ID,
+      params: {},
+    } as unknown as Rule;
+
+    const { result } = renderHook(() => useDiscoverUrl({ alert: alertWithUrl, rule }));
+
+    expect(result.current.discoverUrl).toBe(expectedDiscoverUrl);
+    expect(mockGetRedirectUrl).not.toHaveBeenCalled();
+  });
+
+  it('returns null for ES query rule when alert has no URL', () => {
+    const alertWithoutUrl = {
+      ...MOCK_ALERT,
+      fields: {},
+    } as unknown as TopAlert;
+
+    const rule = {
+      ruleTypeId: ES_QUERY_ID,
+      params: {},
+    } as unknown as Rule;
+
+    const { result } = renderHook(() => useDiscoverUrl({ alert: alertWithoutUrl, rule }));
+
+    expect(result.current.discoverUrl).toBeNull();
+    expect(mockGetRedirectUrl).not.toHaveBeenCalled();
+  });
+
+  it('builds Discover url for SLO burn rate rule when alert has dataViewId', () => {
+    const expectedDataViewId = 'slo-data-view-id';
+    const alertWithDataViewId = {
+      ...MOCK_ALERT,
+      fields: {
+        'slo.dataViewId': expectedDataViewId,
+      },
+    } as unknown as TopAlert;
+
+    const rule = {
+      ruleTypeId: SLO_BURN_RATE_RULE_TYPE_ID,
+      params: {
+        sloId: 'test-slo-id',
+      },
+    } as unknown as Rule;
+
+    const expectedTimeRange = {
+      from: moment(MOCK_ALERT.start).subtract(30, 'minutes').toISOString(),
+      to: moment(MOCK_ALERT.start).add(30, 'minutes').toISOString(),
+    };
+
+    mockGetRedirectUrl.mockReturnValue('slo-discover-url');
+
+    const { result } = renderHook(() => useDiscoverUrl({ alert: alertWithDataViewId, rule }));
+
+    expect(mockGetRedirectUrl).toHaveBeenCalledWith({
+      dataViewId: expectedDataViewId,
+      timeRange: expectedTimeRange,
+    });
+    expect(result.current.discoverUrl).toBe('slo-discover-url');
+  });
+
+  it('returns null for SLO burn rate rule when alert has no dataViewId', () => {
+    const alertWithoutDataViewId = {
+      ...MOCK_ALERT,
+      fields: {},
+    } as unknown as TopAlert;
+
+    const rule = {
+      ruleTypeId: SLO_BURN_RATE_RULE_TYPE_ID,
+      params: {
+        sloId: 'test-slo-id',
+      },
+    } as unknown as Rule;
+
+    const { result } = renderHook(() => useDiscoverUrl({ alert: alertWithoutDataViewId, rule }));
+
+    expect(result.current.discoverUrl).toBeNull();
+    expect(mockGetRedirectUrl).not.toHaveBeenCalled();
+  });
+
   it('ignores unsupported rule types', () => {
     const rule = {
       ruleTypeId: 'some_unsupported_rule',