[ES|QL] Cleanup of the autocomplete and validation package (#244720)

## Summary

Part of #243935

This is the first step:

- I am removing duplicates between ast and validation packages
- Moved functions and files around in order to make more sense
- Cleanup of unused functions
- Folders restructure

### Checklist
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Author: stratoula

src/platform/packages/shared/kbn-esql-ast/src/__tests__/autocomplete.ts

@@ -33,7 +33,7 @@ import {
   inOperators,
   nullCheckOperators,
 } from '../definitions/all_operators';
-import { parse } from '../parser';
+import { Parser } from '../parser';
 import type { ESQLAstAllCommands } from '../types';
 import type {
   FieldType,
@@ -83,12 +83,12 @@ export const suggest = (
 ): Promise<ISuggestionItem[]> => {
   const innerText = query.substring(0, offset ?? query.length);
   const correctedQuery = correctQuerySyntax(innerText);
-  const { ast, root } = parse(correctedQuery, { withFormatting: true });
+  const { root } = Parser.parse(correctedQuery, { withFormatting: true });
   const headerConstruction = root?.header?.find((cmd) => cmd.name === commandName);
 
   const cursorPosition = offset ?? query.length;
 
-  const command = headerConstruction ?? findAstPosition(ast, cursorPosition).command;
+  const command = headerConstruction ?? findAstPosition(root, cursorPosition).command;
 
   if (!command) {
     throw new Error(`${commandName.toUpperCase()} command not found in the parsed query`);

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/dissect/autocomplete.ts

@@ -41,7 +41,7 @@ export async function autocomplete(
   // If cursor is inside a string literal, don't suggest anything
   const correctedQuery = correctQuerySyntax(innerText);
   const { root } = Parser.parse(correctedQuery, { withFormatting: true });
-  const { node } = findAstPosition(root.commands, innerText.length);
+  const { node } = findAstPosition(root, innerText.length);
 
   if (node?.type === 'literal' && node.literalType === 'keyword') {
     return [];

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/fork/autocomplete.test.ts

@@ -25,7 +25,7 @@ import type { ICommandCallbacks } from '../../types';
 import type { FunctionReturnType, FieldType } from '../../../definitions/types';
 import { ESQL_STRING_TYPES, ESQL_NUMBER_TYPES } from '../../../definitions/types';
 import { correctQuerySyntax, findAstPosition } from '../../../definitions/utils/ast';
-import { parse } from '../../../parser';
+import { Parser } from '../../../parser';
 
 const allEvalFnsForWhere = getFunctionSignaturesByReturnType(Location.WHERE, 'any', {
   scalar: true,
@@ -415,9 +415,10 @@ describe('FORK Autocomplete', () => {
       it('suggests pipe after complete subcommands', async () => {
         const assertSuggestsPipe = async (query: string) => {
           const correctedQuery = correctQuerySyntax(query);
-          const { ast } = parse(correctedQuery, { withFormatting: true });
+          const { root } = Parser.parse(correctedQuery, { withFormatting: true });
+
           const cursorPosition = query.length;
-          const { command } = findAstPosition(ast, cursorPosition);
+          const { command } = findAstPosition(root, cursorPosition);
           if (!command) {
             throw new Error('Command not found in the parsed query');
           }

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/from/autocomplete.test.ts

@@ -95,9 +95,10 @@ describe('FROM Autocomplete', () => {
     test('suggests comma or pipe after complete index name', async () => {
       const suggest = async (query: string) => {
         const correctedQuery = correctQuerySyntax(query);
-        const { ast } = Parser.parse(correctedQuery, { withFormatting: true });
+        const { root } = Parser.parse(correctedQuery, { withFormatting: true });
+
         const cursorPosition = query.length;
-        const { command } = findAstPosition(ast, cursorPosition);
+        const { command } = findAstPosition(root, cursorPosition);
 
         return autocomplete(query, command!, mockCallbacks, mockContext, cursorPosition);
       };

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/grok/autocomplete.ts

@@ -30,7 +30,7 @@ export async function autocomplete(
   // If cursor is inside a string literal, don't suggest anything
   const correctedQuery = correctQuerySyntax(innerText);
   const { root } = Parser.parse(correctedQuery, { withFormatting: true });
-  const { node } = findAstPosition(root.commands, innerText.length);
+  const { node } = findAstPosition(root, innerText.length);
 
   if (node?.type === 'literal' && node.literalType === 'keyword') {
     return [];

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/autocomplete.test.ts

@@ -34,7 +34,7 @@ import {
   ESQL_COMMON_NUMERIC_TYPES,
 } from '../../../definitions/types';
 import { correctQuerySyntax, findAstPosition } from '../../../definitions/utils/ast';
-import { parse } from '../../../parser';
+import { Parser } from '../../../parser';
 import { setTestFunctions } from '../../../definitions/utils/test_functions';
 import { getDateHistogramCompletionItem } from '../../../..';
 
@@ -126,9 +126,9 @@ describe('STATS Autocomplete', () => {
 
   const suggest = async (query: string) => {
     const correctedQuery = correctQuerySyntax(query);
-    const { ast } = parse(correctedQuery, { withFormatting: true });
+    const { root } = Parser.parse(correctedQuery, { withFormatting: true });
     const cursorPosition = query.length;
-    const { command } = findAstPosition(ast, cursorPosition);
+    const { command } = findAstPosition(root, cursorPosition);
     if (!command) {
       throw new Error('Command not found in the parsed query');
     }

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/stats/autocomplete.ts

@@ -18,6 +18,7 @@ import type {
   ESQLAstItem,
   ESQLSingleAstItem,
   ESQLAstAllCommands,
+  ESQLAstQueryExpression,
 } from '../../../types';
 import { type ISuggestionItem, type ICommandContext } from '../../types';
 import {
@@ -469,7 +470,13 @@ function findFunctionForSuggestions(
   command: ESQLAstAllCommands,
   cursorPosition: number
 ): ESQLFunction | null {
-  const { node, containingFunction } = findAstPosition([command], cursorPosition);
+  const { node, containingFunction } = findAstPosition(
+    {
+      type: 'query' as const,
+      commands: [command],
+    } as unknown as ESQLAstQueryExpression,
+    cursorPosition
+  );
 
   if (node && node.type === 'function') {
     const fn = node as ESQLFunction;

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/timeseries/autocomplete.test.ts

@@ -11,7 +11,7 @@ import { autocomplete } from './autocomplete';
 import { expectSuggestions } from '../../../__tests__/autocomplete';
 import type { ICommandCallbacks } from '../../types';
 import { correctQuerySyntax, findAstPosition } from '../../../definitions/utils/ast';
-import { parse } from '../../../parser';
+import { Parser } from '../../../parser';
 import { METADATA_FIELDS } from '../../options/metadata';
 import { getRecommendedQueriesTemplatesFromExtensions } from '../../options/recommended_queries';
 
@@ -60,9 +60,10 @@ describe('TS Autocomplete', () => {
   describe('... <sources> ...', () => {
     const suggest = async (query: string) => {
       const correctedQuery = correctQuerySyntax(query);
-      const { ast } = parse(correctedQuery, { withFormatting: true });
+      const { root } = Parser.parse(correctedQuery, { withFormatting: true });
+
       const cursorPosition = query.length;
-      const { command } = findAstPosition(ast, cursorPosition);
+      const { command } = findAstPosition(root, cursorPosition);
       if (!command) {
         throw new Error('Command not found in the parsed query');
       }

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/where/autocomplete.test.ts

@@ -27,7 +27,7 @@ import type { ICommandCallbacks } from '../../types';
 import { ESQL_COMMON_NUMERIC_TYPES } from '../../../definitions/types';
 import { getDateLiterals } from '../../../definitions/utils';
 import { correctQuerySyntax, findAstPosition } from '../../../definitions/utils/ast';
-import { parse } from '../../../parser';
+import { Parser } from '../../../parser';
 
 const allEvalFns = getFunctionSignaturesByReturnType(Location.WHERE, 'any', {
   scalar: true,
@@ -79,9 +79,10 @@ describe('WHERE Autocomplete', () => {
   describe('within the expression', () => {
     const suggest = async (query: string) => {
       const correctedQuery = correctQuerySyntax(query);
-      const { ast } = parse(correctedQuery, { withFormatting: true });
+      const { root } = Parser.parse(correctedQuery, { withFormatting: true });
+
       const cursorPosition = query.length;
-      const { command } = findAstPosition(ast, cursorPosition);
+      const { command } = findAstPosition(root, cursorPosition);
       if (!command) {
         throw new Error('Command not found in the parsed query');
       }

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/location.ts

@@ -55,7 +55,8 @@ const functionBasedLocations: Record<
  *
  * This is primarily around for backwards compatibility with the old system of command and option names.
  */
-const getLocationFromCommandOrOptionName = (name: string) => commandOptionNameToLocation[name];
+export const getLocationFromCommandOrOptionName = (name: string) =>
+  commandOptionNameToLocation[name];
 
 /**
  * Identifies the location ID at the given position