Skip to content

Commit 2866764

Browse files
authored
[ResponseOps][Connectors] Jira Service Management Connector phase 2 (#235408)
## 📄 Summary > [!IMPORTANT] > This PR completes the intermediate release process for the new JSM connector. - Enables the JSM connector UI - Unskips/adds back UI-related tests ## 🧪 Verification steps The JSM connector UI was verified in the [phase 1 PR](#231155). <details> <summary> ## 🔗 References Closes #231571 ## Release Notes Adds a new Connector for Jira Service Management ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] ~~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] ~~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~~ - [ ] ~~This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations.~~ - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
1 parent 43638e1 commit 2866764

File tree

4 files changed

+387
-7
lines changed
  • x-pack/platform

4 files changed

+387
-7
lines changed

x-pack/platform/plugins/shared/stack_connectors/public/connector_types/jira-service-management/model.test.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,13 @@ beforeAll(() => {
2727
}
2828
});
2929

30-
// Temporarily skipped until we enable the frontend part of the JSM connector
31-
// https://github.com/elastic/kibana/issues/231571
32-
33-
describe.skip('connectorTypeRegistry.get() works', () => {
30+
describe('connectorTypeRegistry.get() works', () => {
3431
it('sets the id field in the connector type static data to the correct value', () => {
3532
expect(connectorTypeModel.id).toEqual(JIRA_SERVICE_MANAGEMENT_CONNECTOR_TYPE_ID);
3633
});
3734
});
3835

39-
describe.skip('jira service management action params validation', () => {
36+
describe('jira service management action params validation', () => {
4037
it('results in no errors when the action params are valid for creating an alert', async () => {
4138
const actionParams = {
4239
subAction: JiraServiceManagementSubActions.CreateAlert,

x-pack/platform/plugins/shared/stack_connectors/public/connector_types/jira-service-management/model.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ export const getConnectorType = (): ConnectorTypeModel<
4444
> => {
4545
return {
4646
id: '.jira-service-management',
47-
// Hidden while in intermediate release
48-
hideInUi: true,
4947
iconClass: lazy(() => import('./jsm_logo')),
5048
selectMessage: SELECT_MESSAGE,
5149
actionTypeTitle: TITLE,

x-pack/platform/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ export default ({ loadTestFile }: FtrProviderContext) => {
1111
describe('Connectors', function () {
1212
loadTestFile(require.resolve('./general'));
1313
loadTestFile(require.resolve('./opsgenie'));
14+
loadTestFile(require.resolve('./jsm'));
1415
loadTestFile(require.resolve('./tines'));
1516
loadTestFile(require.resolve('./slack'));
1617
loadTestFile(require.resolve('./webhook'));

0 commit comments

Comments
 (0)