Unify feedbackPanelLocalStorageKey and feedbackSnippetId into one single prop

Author: angeles-mb

src/core/packages/chrome/browser-internal/src/ui/project/sidenav_v2/navigation/navigation_feedback_snippet.tsx

@@ -16,7 +16,6 @@ interface NavigationFeedbackSnippetProps {
   solutionId: SolutionId;
 }
 
-const feedbackPanelLocalStorageKey = 'core.ui.chrome.sideNavigation.feedbackInteraction';
 const feedbackSnippetId = 'sideNavigationFeedback';
 
 const feedbackUrls: { [id in SolutionId]: string } = {
@@ -47,7 +46,6 @@ export const NavigationFeedbackSnippet = ({ solutionId }: NavigationFeedbackSnip
     <FeedbackSnippet
       feedbackButtonMessage={feedbackButtonMessage}
       feedbackSnippetId={feedbackSnippetId}
-      feedbackPanelLocalStorageKey={feedbackPanelLocalStorageKey}
       promptViewMessage={promptViewMessage}
       surveyUrl={feedbackSurveyUrl}
     />

src/platform/packages/shared/shared-ux/feedback_snippet/impl/README.md

@@ -15,7 +15,7 @@ A snippet to gather user feedback. It initially renders as a panel, and once int
 ## Behavior
 The component has two main states:
 - **Panel:** On its first render for a user, the component displays as a full panel with the `promptViewMessage` and options to provide positive ("Yes") or negative ("No") feedback. A "Dismiss" (x) button is also available.
-- **Button:** The component uses the provided `feedbackPanelLocalStorageKey` to track whether the user has interacted with it. If a value is present for that key, the component will render as a button instead.
+- **Button:** The component uses the provided `feedbackSnippetId` to track whether the user has interacted with it. If a value is present for that key, the component will render as a button instead.
 
 ## Feedback Panel Views
 - **Prompt:** The panel shows a custom `promptViewMessage` to gather feedback from the user.

src/platform/packages/shared/shared-ux/feedback_snippet/impl/src/feedback_snippet.tsx

@@ -20,13 +20,9 @@ interface FeedbackSnippetProps {
    */
   feedbackButtonMessage: React.ReactNode;
   /**
-   * HTML id for click tracking purposes.
+   * Id used for local storage and for HTML ids.
    */
   feedbackSnippetId: string;
-  /**
-   * Key for local storage.
-   */
-  feedbackPanelLocalStorageKey: string;
   /**
    * Message to display during the feedback prompt view.
    */
@@ -46,22 +42,21 @@ export type FeedbackView = 'prompt' | 'positive' | 'negative';
 export const FeedbackSnippet = ({
   feedbackButtonMessage,
   feedbackSnippetId,
-  feedbackPanelLocalStorageKey,
   promptViewMessage,
   surveyUrl,
 }: FeedbackSnippetProps) => {
   const [feedbackView, setFeedbackView] = useState<FeedbackView>('prompt');
   const [showPanel, setShowPanel] = useState(() => {
-    return localStorage.getItem(feedbackPanelLocalStorageKey) === null;
+    return localStorage.getItem(feedbackSnippetId) === null;
   });
 
   const handleOpenSurvey = () => {
     window.open(surveyUrl, '_blank');
   };
 
   const storeFeedbackInteraction = useCallback(() => {
-    localStorage.setItem(feedbackPanelLocalStorageKey, Date.now().toString());
-  }, [feedbackPanelLocalStorageKey]);
+    localStorage.setItem(feedbackSnippetId, Date.now().toString());
+  }, [feedbackSnippetId]);
 
   const handleDismissPanel = useCallback(() => {
     setShowPanel(false);