Address feedback

Author: ElenaStoeva

x-pack/platform/plugins/shared/streams/common/constants.ts

@@ -25,8 +25,6 @@ export const STREAMS_UI_PRIVILEGES = {
   show: 'show',
 } as const;
 
-export const FAILURE_STORE_PRIVILEGE = 'read_failure_store';
-
 /**
  * Tiered features
  */

x-pack/platform/plugins/shared/streams/server/routes/internal/streams/crud/route.ts

@@ -11,7 +11,7 @@ import type { estypes } from '@elastic/elasticsearch';
 import type { ClassicIngestStreamEffectiveLifecycle } from '@kbn/streams-schema';
 import { Streams } from '@kbn/streams-schema';
 import { processAsyncInChunks } from '../../../../utils/process_async_in_chunks';
-import { STREAMS_API_PRIVILEGES, FAILURE_STORE_PRIVILEGE } from '../../../../../common/constants';
+import { STREAMS_API_PRIVILEGES } from '../../../../../common/constants';
 import { createServerRoute } from '../../../create_server_route';
 import { getDataStreamLifecycle } from '../../../../lib/streams/stream_crud';
 
@@ -39,10 +39,6 @@ export const listStreamsRoute = createServerRoute({
 
     const streamNames = streams.filter(({ exists }) => exists).map(({ stream }) => stream.name);
 
-    const failureStorePrivileges = await scopedClusterClient.asCurrentUser.security.hasPrivileges({
-      index: [{ names: streamNames, privileges: [FAILURE_STORE_PRIVILEGE] }],
-    });
-
     const dataStreams = await processAsyncInChunks(streamNames, (streamNamesChunk) =>
       scopedClusterClient.asCurrentUser.indices.getDataStream({ name: streamNamesChunk })
     );
@@ -58,8 +54,6 @@ export const listStreamsRoute = createServerRoute({
         stream,
         effective_lifecycle: getDataStreamLifecycle(match ?? null),
         data_stream: match,
-        can_read_failure_store:
-          failureStorePrivileges.index?.[stream.name]?.[FAILURE_STORE_PRIVILEGE],
       });
       return acc;
     }, []);

x-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/data_quality_column.tsx

@@ -13,13 +13,9 @@ import { esqlResultToTimeseries } from '../../util/esql_result_to_timeseries';
 import type { StreamHistogramFetch } from '../../hooks/use_streams_histogram_fetch';
 
 export function DataQualityColumn({
-  indexPattern,
   histogramQueryFetch,
-  considerFailedQuality,
 }: {
-  indexPattern: string;
   histogramQueryFetch: StreamHistogramFetch;
-  considerFailedQuality?: boolean;
 }) {
   const histogramQueryResult = useAsync(() => histogramQueryFetch.docCount, [histogramQueryFetch]);
   const failedDocsResult = useAsync(
@@ -52,8 +48,8 @@ export function DataQualityColumn({
   const degradedDocCount = degradedDocsResult?.value
     ? Number(degradedDocsResult.value?.values?.[0]?.[0])
     : 0;
-  const failedDocCount = degradedDocsResult?.value
-    ? Number(failedDocsResult.value.values?.[0]?.[0])
+  const failedDocCount = failedDocsResult?.value
+    ? Number(failedDocsResult.value?.values?.[0]?.[0])
     : 0;
 
   const degradedPercentage = calculatePercentage({
@@ -66,9 +62,7 @@ export function DataQualityColumn({
     count: failedDocCount,
   });
 
-  const quality = considerFailedQuality
-    ? mapPercentageToQuality([degradedPercentage, failedPercentage])
-    : mapPercentageToQuality([degradedPercentage]);
+  const quality = mapPercentageToQuality([degradedPercentage, failedPercentage]);
 
   const isLoading =
     histogramQueryResult.loading || failedDocsResult?.loading || degradedDocsResult.loading;

x-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/tree_table.tsx

@@ -167,13 +167,7 @@ export function StreamsTreeTable({
           dataType: 'number',
           render: (_: unknown, item: TableRow) =>
             item.data_stream ? (
-              <DataQualityColumn
-                indexPattern={item.stream.name}
-                histogramQueryFetch={getStreamDocCounts(item.stream.name)}
-                considerFailedQuality={
-                  item.can_read_failure_store && item.data_stream?.failure_store?.enabled
-                }
-              />
+              <DataQualityColumn histogramQueryFetch={getStreamDocCounts(item.stream.name)} />
             ) : null,
         },
         {

x-pack/platform/plugins/shared/streams_app/public/components/stream_list_view/utils.ts

@@ -128,7 +128,6 @@ export const enrichStream = (node: StreamTree | ListStreamDetail): EnrichedStrea
     stream: node.stream,
     effective_lifecycle: node.effective_lifecycle,
     data_stream: node.data_stream,
-    can_read_failure_store: node.can_read_failure_store,
     nameSortKey,
     documentsCount: 0,
     retentionMs,