Skip to content

Commit 4e7bff5

Browse files
committed
remove replace: true
1 parent ff0c44e commit 4e7bff5

File tree

4 files changed

+12
-18
lines changed

4 files changed

+12
-18
lines changed

x-pack/solutions/observability/plugins/slo/public/pages/slos/components/common/sort_by_select.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,10 @@ export function SLOSortBy({ state, onStateChange, loading }: Props) {
3232
const sortBy = state.sort.by;
3333

3434
const handleChangeSortBy = ({ value, label }: { value: SortField; label: string }) => {
35-
onStateChange(
36-
{
37-
page: 0,
38-
sort: { by: value, direction: state.sort.direction },
39-
},
40-
{ replace: true }
41-
);
35+
onStateChange({
36+
page: 0,
37+
sort: { by: value, direction: state.sort.direction },
38+
});
4239
};
4340

4441
const sortByOptions: Option[] = [

x-pack/solutions/observability/plugins/slo/public/pages/slos/components/grouped_slos/group_view.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export function GroupView({
5555

5656
const { results = [], total = 0 } = data ?? {};
5757
const handlePageClick = (pageNumber: number) => {
58-
onStateChange({ page: pageNumber }, { replace: true });
58+
onStateChange({ page: pageNumber });
5959
};
6060

6161
if (isLoading || isRefetching) {
@@ -101,7 +101,7 @@ export function GroupView({
101101
itemsPerPage={perPage}
102102
itemsPerPageOptions={[10, 25, 50, 100]}
103103
onChangeItemsPerPage={(newPerPage) => {
104-
onStateChange({ perPage: newPerPage, page: 0 }, { replace: true });
104+
onStateChange({ perPage: newPerPage, page: 0 });
105105
}}
106106
/>
107107
</EuiFlexItem>

x-pack/solutions/observability/plugins/slo/public/pages/slos/components/slo_list_group_by.tsx

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,10 @@ export function SloGroupBy({ onStateChange, state, loading }: Props) {
3737
settings && (settings.useAllRemoteClusters || settings.selectedRemoteClusters.length > 0);
3838

3939
const handleChangeGroupBy = (value: GroupByField) => {
40-
onStateChange(
41-
{
42-
page: 0,
43-
groupBy: value,
44-
},
45-
{ replace: true }
46-
);
40+
onStateChange({
41+
page: 0,
42+
groupBy: value,
43+
});
4744
};
4845
const groupByOptions: Option[] = [
4946
{

x-pack/solutions/observability/plugins/slo/public/pages/slos/components/ungrouped_slos/ungrouped_view.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ export function UngroupedView({ sloList, loading, error, view }: Props) {
3333
pageCount={Math.ceil(total / perPage)}
3434
activePage={page}
3535
onChangePage={(newPage) => {
36-
onStateChange({ page: newPage }, { replace: true });
36+
onStateChange({ page: newPage });
3737
}}
3838
itemsPerPage={perPage}
3939
itemsPerPageOptions={[10, 25, 50, 100]}
4040
onChangeItemsPerPage={(newPerPage) => {
41-
onStateChange({ perPage: newPerPage, page: 0 }, { replace: true });
41+
onStateChange({ perPage: newPerPage, page: 0 });
4242
}}
4343
/>
4444
</EuiFlexItem>

0 commit comments

Comments
 (0)