refactor selector

Author: AlejandroFrndz

x-pack/platform/plugins/shared/streams_app/public/components/data_management/management_bottom_bar/index.tsx

@@ -8,9 +8,8 @@
 import React from 'react';
 import { EuiButton, EuiButtonEmpty, EuiFlexGroup, EuiToolTip, EuiBottomBar } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
-import type { StreamType } from '../../../telemetry/types';
 import { useDiscardConfirm } from '../../../hooks/use_discard_confirm';
-import { selectStreamTypeForTelemetry } from '../stream_detail_enrichment/state_management/stream_enrichment_state_machine/selectors';
+import { selectStreamType } from '../stream_detail_enrichment/state_management/stream_enrichment_state_machine/selectors';
 import { useStreamEnrichmentSelector } from '../stream_detail_enrichment/state_management/stream_enrichment_state_machine';
 
 interface ManagementBottomBarProps {
@@ -32,9 +31,7 @@ export function ManagementBottomBar({
   onCancel,
   onConfirm,
 }: ManagementBottomBarProps) {
-  const streamType: StreamType = useStreamEnrichmentSelector((snapshot) =>
-    selectStreamTypeForTelemetry(snapshot.context)
-  );
+  const streamType = useStreamEnrichmentSelector((snapshot) => selectStreamType(snapshot.context));
 
   const handleCancel = useDiscardConfirm(onCancel, {
     title: discardUnsavedChangesTitle,

x-pack/platform/plugins/shared/streams_app/public/components/data_management/shared/condition_editor.tsx

@@ -26,7 +26,6 @@ import {
 import type { RoutingStatus } from '@kbn/streams-schema';
 import React, { useMemo } from 'react';
 import useToggle from 'react-use/lib/useToggle';
-import type { StreamType } from '../../../telemetry/types';
 import {
   alwaysToEmptyEquals,
   conditionNeedsValueField,
@@ -37,7 +36,7 @@ import type { Suggestion } from './autocomplete_selector';
 import { AutocompleteSelector } from './autocomplete_selector';
 import { OperatorSelector } from './operator_selector';
 import { useStreamEnrichmentSelector } from '../stream_detail_enrichment/state_management/stream_enrichment_state_machine';
-import { selectStreamTypeForTelemetry } from '../stream_detail_enrichment/state_management/stream_enrichment_state_machine/selectors';
+import { selectStreamType } from '../stream_detail_enrichment/state_management/stream_enrichment_state_machine/selectors';
 
 export interface ConditionEditorProps {
   condition: Condition;
@@ -132,9 +131,7 @@ function FilterConditionForm(props: {
 }) {
   const { condition, disabled, onConditionChange, fieldSuggestions, valueSuggestions } = props;
 
-  const streamType: StreamType = useStreamEnrichmentSelector((snapshot) =>
-    selectStreamTypeForTelemetry(snapshot.context)
-  );
+  const streamType = useStreamEnrichmentSelector((snapshot) => selectStreamType(snapshot.context));
 
   const operator = useMemo(() => {
     return getFilterOperator(condition);

x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_enrichment/create_step_button.tsx

@@ -17,12 +17,11 @@ import {
 import React from 'react';
 import useToggle from 'react-use/lib/useToggle';
 import { i18n } from '@kbn/i18n';
-import type { StreamType } from '../../../telemetry/types';
 import {
   useStreamEnrichmentEvents,
   useStreamEnrichmentSelector,
 } from './state_management/stream_enrichment_state_machine';
-import { selectStreamTypeForTelemetry } from './state_management/stream_enrichment_state_machine/selectors';
+import { selectStreamType } from './state_management/stream_enrichment_state_machine/selectors';
 
 const createConditionText = i18n.translate(
   'xpack.streams.streamDetailView.managementTab.enrichment.createConditionButtonText',
@@ -69,9 +68,7 @@ export const CreateStepButton: React.FC<AddStepProps> = ({
     (state) => state.can({ type: 'step.addProcessor' }) || state.can({ type: 'step.addCondition' })
   );
 
-  const streamType: StreamType = useStreamEnrichmentSelector((snapshot) =>
-    selectStreamTypeForTelemetry(snapshot.context)
-  );
+  const streamType = useStreamEnrichmentSelector((snapshot) => selectStreamType(snapshot.context));
 
   const [isPopoverOpen, togglePopover] = useToggle(false);
 

x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_enrichment/state_management/stream_enrichment_state_machine/selectors.ts

@@ -7,7 +7,7 @@
 
 import { createSelector } from 'reselect';
 import { isActionBlock } from '@kbn/streamlang';
-import { Streams } from '@kbn/streams-schema';
+import { getStreamTypeFromDefinition } from '../../../../../util/get_stream_type_from_definition';
 import type { StreamEnrichmentContextType } from './types';
 import { isStepUnderEdit } from '../steps_state_machine';
 import type { StreamType } from '../../../../../telemetry/types';
@@ -58,17 +58,9 @@ export const selectWhetherAnyProcessorBeforePersisted = createSelector(
   }
 );
 
-export const selectStreamTypeForTelemetry = createSelector(
+export const selectStreamType = createSelector(
   [(context: StreamEnrichmentContextType) => context.definition],
   (definition): StreamType => {
-    if (Streams.WiredStream.GetResponse.is(definition)) {
-      return 'wired';
-    }
-
-    if (Streams.ClassicStream.GetResponse.is(definition)) {
-      return 'classic';
-    }
-
-    return 'unknown';
+    return getStreamTypeFromDefinition(definition.stream);
   }
 );

x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_enrichment/steps/blocks/action/index.tsx

@@ -10,7 +10,6 @@ import React, { useEffect, useRef } from 'react';
 import { EuiPanel, useEuiTheme } from '@elastic/eui';
 import { useFirstMountState } from 'react-use/lib/useFirstMountState';
 import { css } from '@emotion/react';
-import type { StreamType } from '../../../../../../telemetry/types';
 import {
   useSimulatorSelector,
   useStreamEnrichmentSelector,
@@ -21,7 +20,7 @@ import type { ProcessorMetrics } from '../../../state_management/simulation_stat
 import { ActionBlockEditor } from './editor';
 import { ActionBlockListItem } from './list_item';
 import { getStepPanelColour } from '../../../utils';
-import { selectStreamTypeForTelemetry } from '../../../state_management/stream_enrichment_state_machine/selectors';
+import { selectStreamType } from '../../../state_management/stream_enrichment_state_machine/selectors';
 
 export type ActionBlockProps = StepConfigurationProps & {
   processorMetrics?: ProcessorMetrics;
@@ -34,9 +33,7 @@ export function ActionBlock(props: StepConfigurationProps) {
 
   const simulation = useSimulatorSelector((snapshot) => snapshot.context.simulation);
 
-  const streamType: StreamType = useStreamEnrichmentSelector((snapshot) =>
-    selectStreamTypeForTelemetry(snapshot.context)
-  );
+  const streamType = useStreamEnrichmentSelector((snapshot) => selectStreamType(snapshot.context));
 
   const panelColour = getStepPanelColour(level);
 

x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_enrichment/steps/blocks/where/configuration.tsx

@@ -22,7 +22,6 @@ import type { SubmitHandler } from 'react-hook-form';
 import { useForm, FormProvider, useController } from 'react-hook-form';
 import type { DeepPartial } from 'utility-types';
 import { useSelector } from '@xstate5/react';
-import type { StreamType } from '../../../../../../telemetry/types';
 import { useDiscardConfirm } from '../../../../../../hooks/use_discard_confirm';
 import {
   useStreamEnrichmentSelector,
@@ -35,7 +34,7 @@ import {
 } from '../../../utils';
 import { discardChangesPromptOptions, deleteConditionPromptOptions } from './prompt_options';
 import { ProcessorConditionEditorWrapper } from '../../../processor_condition_editor';
-import { selectStreamTypeForTelemetry } from '../../../state_management/stream_enrichment_state_machine/selectors';
+import { selectStreamType } from '../../../state_management/stream_enrichment_state_machine/selectors';
 
 interface WhereBlockConfigurationProps {
   stepRef: StreamEnrichmentContextType['stepRefs'][number];
@@ -51,8 +50,8 @@ export const WhereBlockConfiguration = forwardRef<HTMLDivElement, WhereBlockConf
     const canDelete = useSelector(stepRef, (snapshot) => snapshot.can({ type: 'step.delete' }));
     const canSave = useSelector(stepRef, (snapshot) => snapshot.can({ type: 'step.save' }));
 
-    const streamType: StreamType = useStreamEnrichmentSelector((snapshot) =>
-      selectStreamTypeForTelemetry(snapshot.context)
+    const streamType = useStreamEnrichmentSelector((snapshot) =>
+      selectStreamType(snapshot.context)
     );
 
     const [defaultValues] = useState(() =>