Prepare feedbackCallout test utilities for side nav v2 and reenable search feedback test

Author: angeles-mb

src/core/packages/chrome/navigation/src/components/feedback_snippet/feedback_button.tsx

@@ -28,6 +28,7 @@ export const FeedbackButton = ({ handleOpenSurvey }: FeedbackButtonProps) => {
 
   return (
     <EuiButtonEmpty
+      data-test-subj="sideNavFeedbackButton"
       onClick={handleOpenSurvey}
       css={css`
         margin: ${euiTheme.size.m};

src/core/packages/chrome/navigation/src/components/feedback_snippet/feedback_panel.tsx

@@ -97,6 +97,7 @@ export const FeedbackPanel = ({
   const closePanelIcon = (
     <EuiFlexItem grow={false}>
       <EuiButtonIcon
+        data-test-subj="sideNavFeedbackPanelDismiss"
         iconType="cross"
         color="text"
         onClick={handleDismissPanel}
@@ -172,6 +173,7 @@ export const FeedbackPanel = ({
 
   return (
     <EuiPanel
+      data-test-subj="sideNavFeedbackPanel"
       grow={false}
       hasShadow
       css={css`

src/platform/test/functional/page_objects/solution_navigation.ts

@@ -217,6 +217,7 @@ export function SolutionNavigationProvider(ctx: Pick<FtrProviderContext, 'getSer
       },
       async clickPanelLink(deepLinkId: string) {
         if (await isV2()) {
+          await this.feedbackCallout.dismiss();
           await this.clickLink({ deepLinkId: deepLinkId as AppDeepLinkId });
         } else {
           await testSubjects.click(`~panelNavItem-id-${deepLinkId}`);
@@ -354,14 +355,33 @@ export function SolutionNavigationProvider(ctx: Pick<FtrProviderContext, 'getSer
         }
       },
       feedbackCallout: {
+        async getFeedbackTestSubjectId() {
+          return (await isV2()) ? 'sideNavFeedbackPanel' : 'sideNavfeedbackCallout';
+        },
+        async getFeedbackDismissTestSubjectId() {
+          return (await isV2())
+            ? 'sideNavFeedbackPanel > sideNavFeedbackPanelDismiss'
+            : 'sideNavfeedbackCallout > euiDismissCalloutButton';
+        },
         async expectExists() {
-          await testSubjects.existOrFail('sideNavfeedbackCallout', { timeout: TIMEOUT_CHECK });
+          await testSubjects.existOrFail(await this.getFeedbackTestSubjectId(), {
+            timeout: TIMEOUT_CHECK,
+          });
         },
         async expectMissing() {
-          await testSubjects.missingOrFail('sideNavfeedbackCallout', { timeout: TIMEOUT_CHECK });
+          return (await isV2())
+            ? await testSubjects.existOrFail('sideNavFeedbackButton', {
+                timeout: TIMEOUT_CHECK,
+              })
+            : await testSubjects.missingOrFail(await this.getFeedbackTestSubjectId(), {
+                timeout: TIMEOUT_CHECK,
+              });
         },
         async dismiss() {
-          await testSubjects.click('sideNavfeedbackCallout > euiDismissCalloutButton');
+          const feedbackTestSubjectId = await this.getFeedbackTestSubjectId();
+          if (await testSubjects.exists(feedbackTestSubjectId, { timeout: TIMEOUT_CHECK })) {
+            await testSubjects.click(await this.getFeedbackDismissTestSubjectId());
+          }
         },
       },
     },

x-pack/solutions/search/test/functional_solution_sidenav/tests/search_sidenav.ts

@@ -80,8 +80,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       });
 
       it('renders a feedback callout', async function () {
-        await solutionNavigation.sidenav.skipIfV2(this);
-
+        await solutionNavigation.sidenav.clickLink({ navId: 'stack_management' });
         await solutionNavigation.sidenav.feedbackCallout.expectExists();
         await solutionNavigation.sidenav.feedbackCallout.dismiss();
         await solutionNavigation.sidenav.feedbackCallout.expectMissing();

x-pack/solutions/search/test/serverless/functional/test_suites/navigation.ts

@@ -129,8 +129,8 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
       // > Management
       await solutionNavigation.sidenav.clickLink({ navId: 'management' });
       await solutionNavigation.sidenav.expectLinkActive({ navId: 'management' });
-      await svlCommonNavigation.sidenav.clickPanelLink('management:transform');
-      await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Management', 'Transforms']);
+      await svlCommonNavigation.sidenav.clickPanelLink('management:tags');
+      await svlCommonNavigation.breadcrumbs.expectBreadcrumbTexts(['Management', 'Tags']);
 
       // navigate back to serverless search overview
       await svlCommonNavigation.clickLogo();