[Security assistant] Fix System Prompt updates from Conversations tab (#234812)

(cherry picked from commit 540e69f)

Author: stephmilovic

x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/settings/assistant_settings_management.test.tsx

@@ -27,6 +27,8 @@ import {
 import { DataViewsContract } from '@kbn/data-views-plugin/public';
 import { SettingsStart } from '@kbn/core-ui-settings-browser';
 
+const mockSetSelectedSettingsTab = jest.fn();
+
 const mockContext = {
   basePromptContexts: MOCK_QUICK_PROMPTS,
   http: {
@@ -36,7 +38,11 @@ const mockContext = {
   assistantAvailability: {
     isAssistantEnabled: true,
     isAssistantManagementEnabled: true,
+    hasConnectorsAllPrivilege: true,
   },
+  selectedSettingsTab: null,
+  setSelectedSettingsTab: mockSetSelectedSettingsTab,
+  navigateToApp: jest.fn(),
 };
 
 const mockDataViews = {
@@ -109,6 +115,34 @@ describe('AssistantSettingsManagement', () => {
     expect(queryByTestId(`bottom-bar`)).not.toBeInTheDocument();
   });
 
+  describe('useEffect behavior', () => {
+    it('calls onTabChange and clears contextSettingsTab when contextSettingsTab is set', () => {
+      const contextWithTab = {
+        ...mockContext,
+        selectedSettingsTab: SYSTEM_PROMPTS_TAB,
+      };
+      (useAssistantContext as jest.Mock).mockImplementation(() => contextWithTab);
+
+      render(<AssistantSettingsManagement {...testProps} />, { wrapper });
+
+      expect(onTabChange).toHaveBeenCalledWith(SYSTEM_PROMPTS_TAB);
+      expect(mockSetSelectedSettingsTab).toHaveBeenCalledWith(null);
+    });
+
+    it('does not call onTabChange when contextSettingsTab is null', () => {
+      const contextWithoutTab = {
+        ...mockContext,
+        selectedSettingsTab: null,
+      };
+      (useAssistantContext as jest.Mock).mockImplementation(() => contextWithoutTab);
+
+      render(<AssistantSettingsManagement {...testProps} />, { wrapper });
+
+      expect(onTabChange).not.toHaveBeenCalled();
+      expect(mockSetSelectedSettingsTab).not.toHaveBeenCalled();
+    });
+  });
+
   describe.each([
     CONNECTORS_TAB,
     ANONYMIZATION_TAB,

x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/settings/assistant_settings_management.tsx

@@ -59,6 +59,7 @@ export const AssistantSettingsManagement: React.FC<Props> = React.memo(
       if (contextSettingsTab) {
         // contextSettingsTab can be selected from Conversations > System Prompts > Add System Prompt
         onTabChange?.(contextSettingsTab);
+        setSelectedSettingsTab(null);
       }
     }, [onTabChange, contextSettingsTab, setSelectedSettingsTab]);